Repository navigation
ci(scout): scan for CVEs in one step, ask for base-image advice in another - #76
Merged
Merged
Conversation
…other From 2026-10-24 every run of docker-scout.yml failed, and GitHub mailed a failure for each push to main: the CVE scan worked and was printed, then the scout CLI crashed in the recommendations part (panic, nil pointer in internal/format/recommendations/markdown.go) on images built on python:3.12-slim-trixie, with scout-action 1.27 and 1.28 alike. The scan is now a step of its own (command: cves) that writes the SARIF and fails the job if it fails. The recommendations are a second step with continue-on-error: a crash in advice shows in the log and no longer turns a working scan red. docker.yml scanned with cves alone and is unchanged. tests/test_scout_steps.py holds the two apart. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced Oct 28, 2026
Merged
maksimtech
added a commit
to maksimtech/cookieradar
that referenced
this pull request
Oct 28, 2026
…other (#59) From 2026-10-24 every run of docker-scout.yml failed, and GitHub mailed a failure for each push to main: the CVE scan worked and was printed, then the scout CLI crashed in the recommendations part (panic, nil pointer in internal/format/recommendations/markdown.go) on images built on python:3.12-slim-trixie. The scan is now a step of its own (command: cves) that writes the SARIF and fails the job if it fails. The recommendations are a second step with continue-on-error: a crash in advice shows in the log and no longer turns a working scan red. tests/test_scout_steps.py holds the two apart. Same change as maksimtech/mailradar#76. Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
maksimtech
added a commit
to maksimtech/apkradar
that referenced
this pull request
Oct 28, 2026
…other (#52) From 2026-10-24 every run of docker-scout.yml failed, and GitHub mailed a failure for each push to main: the CVE scan worked and was printed, then the scout CLI crashed in the recommendations part (panic, nil pointer in internal/format/recommendations/markdown.go) on images built on python:3.12-slim-trixie. The scan is now a step of its own (command: cves) that writes the SARIF and fails the job if it fails. The recommendations are a second step with continue-on-error: a crash in advice shows in the log and no longer turns a working scan red. tests/test_scout_steps.py holds the two apart. Same change as maksimtech/mailradar#76. Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
maksimtech
added a commit
to maksimtech/releaseradar
that referenced
this pull request
Oct 28, 2026
…other (#28) From 2026-10-24 every run of docker-scout.yml failed, and GitHub mailed a failure for each push to main: the CVE scan worked and was printed, then the scout CLI crashed in the recommendations part (panic, nil pointer in internal/format/recommendations/markdown.go) on images built on python:3.12-slim-trixie. The scan is now a step of its own (command: cves) that writes the SARIF and fails the job if it fails. The recommendations are a second step with continue-on-error: a crash in advice shows in the log and no longer turns a working scan red. tests/test_scout_steps.py holds the two apart. Same change as maksimtech/mailradar#76. Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



From 2026-10-24 every run of
docker-scout.ymlfailed, and GitHub mailed a failure for each push to main (seven today). The CVE scan worked and was printed; then the scout CLI crashed in therecommendationspart —panic: runtime error: invalid memory address or nil pointer dereferenceininternal/format/recommendations/markdown.go— on the images built on python:3.12-slim-trixie, with scout-action 1.27 and 1.28 alike. The Security Posture gate stayed green throughout: the SARIF was uploaded before the crash.docker-scout.yml:command: cvesin its own step, writing the SARIF; if it fails, the job does.command: recommendationsin a second step withcontinue-on-error: trueand no SARIF. The comment that explains why the recommendations are worth having moves with them.docker.ymlscanned withcvesalone and is unchanged; a test says so.TDD:
tests/test_scout_steps.py(4 tests on the parsed workflows): not both commands in one step; the scan writes the SARIF and has no continue-on-error; the recommendations have it and write no SARIF; docker.yml stayscvesonly. Red on the first and third before the change; full suite 719 passed.The same crash hits releaseradar, apkradar and cookieradar (also python:3.12); the same change follows there.
🤖 Generated with Claude Code