Repository navigation
ci(scout): scan for CVEs in one step, ask for base-image advice in another - #52
Merged
Merged
Conversation
…other From 2026-10-24 every run of docker-scout.yml failed, and GitHub mailed a failure for each push to main: the CVE scan worked and was printed, then the scout CLI crashed in the recommendations part (panic, nil pointer in internal/format/recommendations/markdown.go) on images built on python:3.12-slim-trixie. The scan is now a step of its own (command: cves) that writes the SARIF and fails the job if it fails. The recommendations are a second step with continue-on-error: a crash in advice shows in the log and no longer turns a working scan red. tests/test_scout_steps.py holds the two apart. Same change as maksimtech/mailradar#76. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Merging this PR will not alter performance
Comparing 
Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same change as maksimtech/mailradar#76, where it shipped in 2026.47 and Docker Scout went green again after the release.
From 2026-10-24 every run of
docker-scout.ymlfailed, and GitHub mailed a failure for each push to main: the CVE scan worked and its SARIF was uploaded, then the scout CLI crashed in therecommendationspart (panic: runtime error: invalid memory address or nil pointer dereferenceininternal/format/recommendations/markdown.go) on this image, built on python:3.12-slim-trixie.docker-scout.yml:command: cvesin its own step, writing the SARIF; if it fails, the job does.command: recommendationsin a second step withcontinue-on-error: trueand no SARIF.TDD:
tests/test_scout_steps.py(4 tests on the parsed workflows), red on two before the change. Full suite: 1302 passed. The action stays as pinned today; pinning every action to a commit is a separate change.🤖 Generated with Claude Code