[MT-23014] Show a friendly state for deleted open messages#42
Merged
Conversation
A message deleted while open (by another client, the API, or retention eviction) surfaced as the raw axios string "Error: AxiosError: Request failed with status code 404" in MessageView. - Add isNotFoundError() to api/client next to isAbortError. - On a 404 load, render an EmptyCard saying the message was deleted, with a "Back to inbox" button instead of the raw error. - Subscribe MessageView to the live channel and swap to the same deleted state when a 'destroyed' frame targets the open message, instead of leaving a stale view. - Non-404 failures now go through extractApiError() for readable copy. Jira: MT-22849 (finding 8) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughMessageView now distinguishes deleted messages from other load failures. It renders a deleted state for 404 responses or matching live ChangesMessage deletion handling
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant MessageView
participant MessagesAPI
participant useMessagesChannel
participant InboxNavigation
MessagesAPI->>MessageView: message load response or 404 error
useMessagesChannel->>MessageView: destroyed frame with message ID
MessageView->>MessageView: set deleted state for matching message
MessageView->>InboxNavigation: navigate back to inbox
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
kyrylo-yevdokymov
marked this pull request as ready for review
July 13, 2026 10:43
solovey23
approved these changes
Jul 14, 2026
leonid-shevtsov
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Fixes MT-23014, a sub-task of MT-22849.
Message API 404s were handled as generic Axios failures, and an externally deleted open message remained stale. This change recognizes the not-found case, reacts to live deletion, and renders a clear recovery state with a route back to the inbox.
Impact
Users no longer see a raw network error when the open message has been deleted.
Screenshots
Verification
npm test— 62 tests passednpm run lint— 0 errors; 4 existing warningsnpm run build— passedgit diff --check main...fix/mt-23014-deleted-message-state— passedSummary by CodeRabbit
New Features
Bug Fixes