[MT-23014] Show a friendly state for deleted open messages#30
Closed
kyrylo-yevdokymov wants to merge 1 commit into
Closed
[MT-23014] Show a friendly state for deleted open messages#30kyrylo-yevdokymov wants to merge 1 commit into
kyrylo-yevdokymov wants to merge 1 commit into
Conversation
A message deleted while open (by another client, the API, or retention eviction) surfaced as the raw axios string "Error: AxiosError: Request failed with status code 404" in MessageView. - Add isNotFoundError() to api/client next to isAbortError. - On a 404 load, render an EmptyCard saying the message was deleted, with a "Back to inbox" button instead of the raw error. - Subscribe MessageView to the live channel and swap to the same deleted state when a 'destroyed' frame targets the open message, instead of leaving a stale view. - Non-404 failures now go through extractApiError() for readable copy. Jira: MT-22849 (finding 8) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Replaced by #42 using the repository-standard fix/mt-23014-deleted-message-state branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Fixes MT-23014, a sub-task of MT-22849.
Message API 404s were handled as generic Axios failures, and an externally deleted open message remained stale. This change recognizes the not-found case, reacts to live deletion, and renders a clear recovery state with a route back to the inbox.
Impact
Users no longer see a raw network error when the open message has been deleted.
Verification
npm test— 62 tests passednpm run lint— 0 errors; 4 existing warningsnpm run build— passedgit diff --check main...codex/mt-23014-deleted-message-state— passed