Repository navigation
Fix doctor ownership for absolute Windows RECORD paths - #8299
Open
loopx-agent wants to merge 1 commit into
Open
loopx-agent wants to merge 1 commit into
loopx-agent wants to merge 1 commit into
Conversation
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
This was referenced Nov 7, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal And Delivered Outcome
On Python 3.11 for Windows,
loopx doctorcan miss the installer that owns the running package. The absoluteD:/…/loopx/doctor.pyentry in installedRECORDis parsed as an importlibPackagePath. Joining its POSIX components to the distribution root can lose the drive root or prepend the metadata directory to an already absolute path. The three existing installer-owner assertions fail on the Windows runner. Main baseline failure and research PR Windows failureMatch candidate rows using the host's path spelling. Resolve native absolute paths directly, retain the distribution's lookup for relative entries and require the resolved path to match the imported module before reporting its installation owner. Installed metadata can contain either absolute or relative paths and either separator on Windows. Python installed metadata specification
Author Declaration
Written by Codex (OpenAI). The existing
doctordistribution metadata adapter owns this decision. Its existing Windows installer-owner tests retain the absolute-path input. Related to #8013, #8287 and #8291. Intended base ismain.Validation
Tested
3b9b8df4b01fa204e7462bfb2f3c4b6b0b07a78eagainst32167518b3c2646fd9b6a3a6e0aaf74b258a7b70.doctorcommand3b9b8df4b01fa204e7462bfb2f3c4b6b0b07a78e, including the lifecycle suite with the original installer-owner cases. Windows jobScope And Continuation
This is a CLI installation metadata compatibility repair. Native Windows CI and independent review qualify integration. The Dashboard qualification changes have their own PR #8296.