Skip to content

Fix Dashboard and Windows release qualification - #8296

Open
loopx-agent wants to merge 6 commits into
mainfrom
codex/report-reader-theme-tokens-20261107
Open

loopx-agent wants to merge 6 commits into
mainfrom
codex/report-reader-theme-tokens-20261107

Conversation

@loopx-agent

@loopx-agent loopx-agent commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator

Goal and delivered outcome

Two shared failures block validation of the research workbench. The Dashboard report reader refers to undefined theme tokens, and the installed browser checks receive two incomplete fixtures. On Python 3.11 for Windows, loopx doctor can also miss the active installer's metadata when RECORD uses an absolute path.

  • Use the existing workspace line and card tokens so the report header, frame, and preview background render with the selected theme. Dashboard failure
  • Give both simulated conversation turns creation timestamps from the browser clock. Exercise the Goal masthead with both bounded attention and the complete owner-facing list. Conversation failure · Masthead failure
  • Parse an absolute RECORD path with the native filesystem rules. Resolve relative rows through the distribution and require the resolved path to match the imported module. Windows failure on the research branch

On this PR’s previous revision, the native Windows job failed all three installer-owner cases. The standalone Windows fix passed them, but its Dashboard shards stopped on the undefined theme tokens. The required Python Tests workflow runs both sets of checks. Windows failure · Dashboard failure on the standalone Windows fix

This PR qualifies both fixes on a single candidate. The Windows change is the existing signed commit from #8299. The research changes are tracked in #8287 and #8291.

Author declaration

Written by Codex (OpenAI). The Dashboard reuses its existing theme tokens and fixture producers. The installation check stays in the existing distribution metadata adapter. The changes are independently reviewable as their original commits.

Validation

Candidate edf32c71931f3773943638ebba26cb71744e7806 against 94b91e48aa4a2cdafe9d4d31d918fe84d0112b41.

Check Result Evidence
CSS audit and Chat build Passed No undefined Dashboard properties. The Chat bundle was verified and built into a clean Python 3.11 wheel.
Installed browser Passed The combined wheel passed conversation activity and the Goal masthead. The same report-reader files previously passed theme, retry, desktop, and 390 px checks.
Installed doctor and targeted tests Passed Relative and absolute RECORD entries identify the installer. A foreign module path is rejected. Six Windows path probes passed. Python 3.11 ran 49 tests with three native-only cases skipped locally.
Native Windows Passed on the standalone fix The original lifecycle tests ran on the exact doctor commit included here. The combined head has its own hosted run. Windows job
Combined local premerge Pending Diff checks, public boundary and the exact change-quality receipt passed. The repository-wide semantic vocabulary check reached the standard 120-second timeout in both local runs. A passing premerge run is still required before merge.
Combined hosted CI and review Pending Full GitHub checks and independent review apply to this exact commit.

Visual evidence

Packaged Chat at 8667bdb3ff3d3e0c139a710b1276b3704d3b0d18 with synthetic reports and the production HTTP reader. The combined candidate retains the same stylesheet and reader behavior. The matched desktop first view shows the restored division between review metadata, controls and content. The long title wraps on the narrow viewport and the preview fits its column. Loading and retry were checked in the same browser journey.

Desktop before, 1440 × 900

public-before

Desktop after, 1440 × 900

public-after

Narrow after, 390 × 900

public-narrow

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
@loopx-agent loopx-agent changed the title Fix workspace theme tokens in the report reader Fix Dashboard qualification for report review Nov 7, 2026
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

@loopx-agent loopx-agent left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer: model_agent, gpt-6.1-sol, OpenAI, runtime_reported, reasoning_effort=max

Approval conclusion (author-owned PR; GitHub blocks formal self-approval)

动机 / Motivation

在 Goal 的成果页审阅报告的人会先看标题和处理入口,再阅读正文。维护者用打包浏览器场景核对哪些任务需要用户决定。 打开同一份长标题报告,旧包的标题与正文没有预期边线。旧打包检查也会把一份完整队列的 1 项阻塞显示判成错误。 独立安装的 head 恢复标题分隔线与报告边框。修正后的浏览器场景把三行预览和完整队列分开,分别验证未知和实际的阻塞数。 两处改动分别落在报告阅读样式和既有测试输入。 这次资格覆盖隔离的打包轮次与合成报告,完整浏览器场景矩阵和用户机器上的发布版留待各自验证。

改动思路 / Approach

报告组件使用现有主题的边线和卡片底色。测试沿用原生 fixture,从顶层列表驱动计数,另保留部分预览对照。 两条 CSS 声明归主题所有,三种队列边界归现有 smoke 和投影适配器。复用混合 fixture 消除一次重复生成。 样式消费既有主题。任务总数仍由原生投影提供,报告读权限由现有读取路径处理。

具体改动 / Changes

基线为 32167518b3c2646fd9b6a3a6e0aaf74b258a7b70。基线的前端交付规范要求从真实入口完成阅读并核对打包页面。这里用同一合成报告和原生任务投影测前后差异。 基线规范

  • Theme boundary。 同一报告在实际打包 Chat 可打开,默认主题的标题分隔和正文框在桌面及窄屏均可见。
  • Qualified counts。 同一修正场景在 main wheel 与 head wheel 均通过。三条预览保留总数且显示未知,完整混合队列为 1 个阻塞、20 项可选,全可选队列为 0 个阻塞、21 项可选。

关键代码讲解

report-review-masthead 和 iframe 使用现有主题边线与卡片底色。

.report-review-masthead { padding: 8px 0; border-bottom: 1px solid var(--pw-line); }

goal-masthead 给实际消费的列表使用三行部分预览,完整混合输入保留 21 行,并断言 20 项可选。

const partial = !["complete", "mixed-complete", "optional"].includes(mode);

对主干的风险 / Risks

修正后的绿色本身无法区分产品和测试问题。我在同一基线 wheel 重跑修正后的场景,同样通过。旧场景失败归于输入,样式修复则由真实报告页的边框与底色证明。页面版继续使用 sandboxed iframe,验收和反馈由原组件分别处理。

PASS。主题审计 39 个样式表、3695 个裸引用通过。两个报告 HTTP 用例通过,打包场景及桌面和窄屏阅读对照通过。 Quick premerge 的 4 项直接检查和 4 项选中检查通过。 与实际目标 main 的合成树干净。 历史对照保留 3 处 CSS 未定义引用和旧场景的 1 vs — 失败。 远端 CI 未取样。

我的整体评价 / Verdict

赞同提交这两个修复。报告页恢复可见边界,打包检查也能分辨预览行数与完整队列分类。 这次资格覆盖隔离的打包轮次与合成报告,完整浏览器场景矩阵和用户机器上的发布版留待各自验证。

我在独立安装的打包 Chat 中核对了 1440 和 390 像素的报告阅读。细线分开标题区、操作区与正文,窄屏的长标题换行,验收与反馈仍能在正文前找到。 范围限于合成报告的默认主题与这两个视口,其他主题与线上数据留待验证。

English verdict: APPROVE. 538814d restores the report reader’s theme borders and background and fixes the masthead fixture. Matched packaged browser and HTTP checks passed. The old fixture failed on the same baseline wheel that passed with the corrected fixture.

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…validation

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
@loopx-agent loopx-agent changed the title Fix Dashboard qualification for report review Fix Dashboard and Windows release qualification Nov 7, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant