Repository navigation
fix(ui): overlays show above the page, plus Edge polish - #94
Merged
Merged
Conversation
The tab views are native views stacked above the shell's document, so the controller keyboard, the menu, the tab grid and the permission prompt all opened behind the web page: on a real window only the toolbar dimmed. The e2e suite checks the DOM, not the composited screen, so it never noticed. - The keyboard reports its height and the page ends above it, staying live so the field being typed into is in sight. - A modal overlay paints a snapshot of the page and only then asks the live view to step aside (new `page-cover` command and `shell:snapshot` channel, both validated). - Toasts and the ads/controller status moved into the toolbar, the only place the shell can be seen; the untranslated startup toast is gone. Polish found on the way: the `…` menu drops down from its button in window mode with distinct icons, the caption shows Restore while maximized, the history and favourites pages now load the design tokens (they never did, so they rendered unstyled), and faint text is raised to keep WCAG AA on the new greys. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Notepad and PowerShell 5 write UTF-8 with a BOM, which JSON.parse refuses: the app then started with every setting at its default (welcome screen, TV mode). Found running the packaged build on Windows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug (pre-existing): tab views are native
WebContentsViews stacked above the shell document, so the controller keyboard, the…menu, the tab grid and the permission prompt all opened behind the web page. On a real Windows window only the toolbar dimmed, as confirmed with desktop screenshots. The e2e suite checks the DOM rather than the composited screen, so it never caught this.chrome-height.bottom) and the page ends above it, staying live so you can see what you type.shell:snapshot) and then sendspage-cover, so the live view steps aside without flicker. Both commands are validated inisShellCommandand unit-tested.Polish
…menu drops down from its button like Edge's; in TV mode it stays centred. The menu items now have distinct icons.maximizedadded to the shell state).tokens.css, so they rendered unstyled. They are now styled, and their search fields are typedsearch.--faintgoes from 50% to 62%, keeping WCAG AA on the new greys and on the Light theme.Test plan
npm run typechecknpm test(101 passed)npm run test:e2e(47 passed, 3 skipped)🤖 Generated with Claude Code