Repository navigation
fix(controller): click of the right stick reaches Cursor mode - #90
Merged
Merged
Conversation
lippdev
force-pushed
the
capy/show-the-keyboard-over
branch
from
October 21, 2026 17:28
f0312ac to
26d3145
Compare
The shell's button map had RightStick on 10, which is the left stick's click: pressing R3 toggled nothing and Cursor mode stayed unreachable by the only button that offers it. The map now comes from the shared table in controllerInput.ts, where RightStick is 11, instead of a second copy that could drift from it. The toolbar hints also name the button (`R3 cursor`), so the one control with no visible counterpart in the UI is discoverable. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
lippdev
force-pushed
the
capy/show-the-keyboard-over
branch
from
October 21, 2026 17:34
26d3145 to
f02d0d9
Compare
capy-ai
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cursor mode could not be reached from a controller at all: the shell's button map put
RightStickon 10, which is the left stick's click, so pressing R3 toggled nothing.shared/controllerInput.tsalready has the correct table (RightStick: 11), and the preload uses it. The shell kept a second copy ingamepad.ts, and that is the one that had drifted. The map now comes from the shared table, so the two cannot disagree again.The toolbar hints also name the button (
R3 cursor). It is the only route into the mode and has no counterpart visible in the UI, so without the hint the mode is undiscoverable.renderer/shell/gamepad.tsButtonfromshared/controllerInputinstead of a local copyshared/controllerGlyphs.tsstickglyph per controller family, allR3renderer/shell/app.tsxR3 cursorin the controller hintstests/e2e/controller.spec.tstests/unit/services.test.tsstickThe keyboard/overlay half of the original change is not here:
maincovered it in #94 with the page snapshot approach (page-cover), which supersedes the viewport insets this branch started with.Verified on
main+ this commit:npm run typecheck,npm test(102),npm run build, and the full Playwright suite underxvfb-run(49 passed, 2 skipped).