Repository navigation
wallet: add the light wallet to the c abi - #26
Open
mycomputercrashsalot wants to merge 1 commit into
Open
mycomputercrashsalot wants to merge 1 commit into
mycomputercrashsalot wants to merge 1 commit into
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 47 |
| Duplication | 6 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
mycomputercrashsalot
force-pushed
the
wallet-light-abi
branch
from
October 31, 2026 01:08
571cfc8 to
5e7b73a
Compare
Author
|
rebased onto the new main (the submodule pin conflicted with the ci changes) — the workflows need an approve-and-run after the force push from the fork |
mycomputercrashsalot
force-pushed
the
wallet-light-abi
branch
from
October 31, 2026 13:44
5e7b73a to
896fc5b
Compare
mycomputercrashsalot
force-pushed
the
wallet-light-abi
branch
from
November 3, 2026 13:08
b4344ed to
eb74ec3
Compare
mycomputercrashsalot
force-pushed
the
wallet-light-abi
branch
3 times, most recently
from
November 6, 2026 12:58
67e4d6a to
667fb26
Compare
mycomputercrashsalot
force-pushed
the
wallet-light-abi
branch
10 times, most recently
from
November 14, 2026 10:28
6490a0f to
61017be
Compare
mycomputercrashsalot
force-pushed
the
wallet-light-abi
branch
from
November 20, 2026 11:05
4c800b3 to
846b157
Compare
mycomputercrashsalot
force-pushed
the
wallet-light-abi
branch
from
November 20, 2026 11:05
846b157 to
a47d9a6
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the light wallet behind the c abi: four functions, and everything else rides the surface the wallet already has
the config is the wallet config the other calls take, with the connection of the server as its own argument: a config that carries a server is rejected on all three paths. the outputs are reset before the call, so a failed call leaves no stale value. the config of the create and the open is wiped after the call, the way the factories of the other wallets wipe theirs. the symbols are in the export lists, and the abi is 0.3.0 on top of 0.2.1: four additions and no change, so a binding that asks for 0.2.x keeps working until it asks for the light calls
the submodule points at the fork of monero-cpp with the lookahead fix: the login response of monero-lws carries the lookahead as maj_i and min_i, not a uint, so every c++ login of a light wallet throws on the parse. that fix is a pr of its own to monero-cpp — this pin is the branch to point at until it lands, and it flips back to the woodser pin with it
rebased on main at 9459b31, after the ci restructuring: the changelog carries the 0.3.0 section above the 0.2.1 one, and the version triple and the abi unit test say 0.3.0
the probe (tests/c/integration, the light probe of the kotlin work) runs all four live against a monero-lws on regtest: the create registers the account, the exists flips, the sync reads the balance of five mined blocks, the reopen reads the same, the unrefined count is zero. it also fails the negative configs and proves the reset of the outputs with pre-filled stale values