Skip to content

[1 XMR + ? XMR] Switch asb wallet to pure monero-oxide #1250

Open

Description

@binarybaron
No description provided.

Activity

  1. binarybaron commented on Nov 3, 2026

    @binarybaron
    Author

    Please do not start working on this without talking to the maintainers, because this issue is highly security relevant and will only be assigned to trusted contributors who can be trusted not to solely use LLM to implement it.

  2. added
    refactoringRelated to refactorings. No new features are added.
    asbRelated to the ASB (maker side)
    Bounty 💸Whoever implements a PR to this issue received the bounty once the PR is merged
    monero-sysRelated to our Monero FFI bindings
    monero-wallet-ngNew Monero wallet based on moner-oxide
    on Nov 3, 2026
  3. mycomputercrashsalot commented on Nov 8, 2026

    @mycomputercrashsalot

    hey binarybaron — saw the new asb bounties. #1250 (asb wallet on pure monero-oxide) is exactly the kind of migration we like: we've done the C-ABI side of this (libmonero/monero-c#26, light-wallet API reviewed upstream) and the kotlin layer (monero-kotlin#13/#14, tests green). before touching anything: what does the maintainer team want the asb wallet to look like after the switch — is monero-oxide far enough along for the asb's send/sync paths now, and is there a migration order you'd prefer? happy to write a short migration plan first so you can judge before any code. also: #828 (alice-locks-wrong-amount integration test) looks clean and unclaimed — we can land that while the #1250 plan is discussed. and if the oxide conversation goes well, #1249 (p2p microservice) is next on our list.

  4. changed the title [-][2 XMR] Switch asb wallet to pure monero-oxide[/-] [+][1 XMR + ? XMR] Switch asb wallet to pure monero-oxide[/+] on Nov 14, 2026
  5. binarybaron commented on Nov 14, 2026

    @binarybaron
    Author

    hey binarybaron — saw the new asb bounties. #1250 (asb wallet on pure monero-oxide) is exactly the kind of migration we like: we've done the C-ABI side of this (libmonero/monero-c#26, light-wallet API reviewed upstream) and the kotlin layer (monero-kotlin#13/#14, tests green). before touching anything: what does the maintainer team want the asb wallet to look like after the switch — is monero-oxide far enough along for the asb's send/sync paths now, and is there a migration order you'd prefer? happy to write a short migration plan first so you can judge before any code. also: #828 (alice-locks-wrong-amount integration test) looks clean and unclaimed — we can land that while the #1250 plan is discussed. and if the oxide conversation goes well, #1249 (p2p microservice) is next on our list.

    Is this message AI-generated? Your background does not look bad, but if you cannot even write a message like this without AI, then I don't think you're the right fit.

  6. binarybaron commented on Nov 14, 2026

    @binarybaron
    Author

    This issue has been assigned a bounty (💰)

    Current bounty:

    We are aiming for a bounty of around 15 XMR given the significance of this issue to the security of the project, as well as the complexity of the task at hand.

    Bounty donation address

    If you want to incentivize work on this issue, you can help increase the bounty by donating to the address below.

    84GbFKdhrGb3NvAzxd3H2GddbwQqpTSx4c8v7BsNeowgL1pT2kjUcvXaLY98N2XBrxD6ZjwpLYKJKbsdbeQdEn8o9LSsyw6
    

    Fine print

    We use bounties to incentivize development and reward contributors. All issues available for a bounty have the Bounty 💰 label.

    To receive the bounty of this issue, you agree to these conditions:

    • Bounties will be set and awarded at discretion of @binarybaron
    • An issue is considered resolved when the patch(es) proposed by the contributor is/are merged in the appropriate repository according to terms of the issue.
    • The first person who resolves an issue in its entirety will receive the entire amount of the bounty.
    • If the issue is resolved collaboratively by more than one person, the reward will be distributed among the contributors

    This bounty may also be rewarded to one of the core developers who will implement it, unless we find someone else who is qualified to do this. We have spoken to one of the original developers from the xmr-btc-swap repository, and they seem somewhat interested, but they haven't confirmed that they have the resources to work on this.

  7. pinned this issue on Nov 14, 2026
  8. mycomputercrashsalot commented on Nov 15, 2026

    @mycomputercrashsalot

    nope, it’s just how I write, not AI.

  9. binarybaron commented on Nov 15, 2026

    @binarybaron
    Author

    nope, it’s just how I write, not AI.

    Ok, I see. You can open a PR for #828 first, then we can talk about this issue!

  10. binarybaron commented on Nov 15, 2026

    @binarybaron
    Author

    As part of this we also want to migrate the testing harness to use monero-oxide exclusively.

  11. mycomputercrashsalot commented on Nov 17, 2026

    @mycomputercrashsalot

    got it — one thingy first: that exact test is already on main, fxrstor landed it in april (bob_refunds_when_xmr_amount_is_not_exact.rs, pr #962), so re-adding it 1:1 would just be noise. what i can do is the part your second message points at: migrate the test harness off monero-wallet-rpc/monero-sys onto monero-oxide exclusively, and land the wrong-amount test on that harness as the proof it works. that's a bigger slice than one test but it's what #1250 actually stands on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Bounty 💸Whoever implements a PR to this issue received the bounty once the PR is mergedasbRelated to the ASB (maker side)monero walletmonero-sysRelated to our Monero FFI bindingsmonero-wallet-ngNew Monero wallet based on moner-oxiderefactoringRelated to refactorings. No new features are added.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions