Repository navigation
feat(packaging): build without the in-app updater and license every file as MIT - #1934
Merged
Merged
Conversation
The project is MIT, but the updater modules, the trash and entry animations, path completion, and the manifest signing script carried GPL-3.0-or-later SPDX headers by mistake. Refs #1933
STRATA_UPDATER=disabled compiles the updater out for distributions whose own packages deliver Strata updates. Such a build never checks for or installs a release, has no Updates page in Settings or search, and reports the disabled updater in Diagnostics. Any other value fails the build so a typo cannot ship an updater. Refs #1933
5 tasks
wmfeht
pushed a commit
to wmfeht/strata-feature-map
that referenced
this pull request
Oct 29, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ABVQmsKTvBAiWPnosE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Distributions that deliver Strata updates through their own packages had no way to turn the in-app updater off. Only pacman-owned installs and the AUR marker suppress it, and the marker's update check queries the AUR. This adds a build-time switch,
STRATA_UPDATER=disabled. A build made with it:The switch accepts only
enabled(the default) anddisabled, so a typo fails the build rather than shipping an updater. It is documented indocs/packaging.mdand the README.Separately, the updater modules,
entry_animation,dissolve_delete,fly_to_trash,location/completion, their tests, andscripts/sign_update_manifest.pycarriedGPL-3.0-or-laterSPDX headers by mistake. They are now MIT like the rest of the project. The third-party GTK/GStreamer patches keep their LGPL notices.Visual evidence
N/A. The change removes the Updates page in a build option and edits license headers.
How to test
STRATA_UPDATER=disabled cargo build --locked --releaseand launch Strata.STRATA_UPDATER=disable: the build fails, naming the accepted values.grep -rn "GPL-3.0" src scriptsprints nothing.Expected result: Disabled builds contain no reachable updater, default builds are unchanged, and every first-party source file is MIT.
Related issue
Closes #1933