Repository navigation
Sync lgse/strata#1934, #1909, #1918, #1837: admin folders, builds without the updater, Hungarian, stale-state fixes - #49
Open
wmfeht wants to merge 17 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ABVQmsKTvBAiWPnosE
…iew and devices nodes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ABVQmsKTvBAiWPnosE
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ABVQmsKTvBAiWPnosE
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ABVQmsKTvBAiWPnosE
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ABVQmsKTvBAiWPnosE
…ss node; regenerate indexes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ABVQmsKTvBAiWPnosE
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ABVQmsKTvBAiWPnosE
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ABVQmsKTvBAiWPnosE
…egenerate indexes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ABVQmsKTvBAiWPnosE
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ABVQmsKTvBAiWPnosE
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ABVQmsKTvBAiWPnosE
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ABVQmsKTvBAiWPnosE
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ABVQmsKTvBAiWPnosE
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ABVQmsKTvBAiWPnosE
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ABVQmsKTvBAiWPnosE
…to its owner Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ABVQmsKTvBAiWPnosE
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ABVQmsKTvBAiWPnosE
5 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #47
Closes #48
Read this first
73b3258. This session can push only to its own branch, so this PR branches from Sync lgse/strata#1912, #1885: remappable per-map keys, uncomposited popovers, typed-path preview #47's head and targets Sync lgse/strata#1912, #1885: remappable per-map keys, uncomposited popovers, typed-path preview #47's branch.resync/full-audit, which already merged intomainas Full resync at lgse/strata 86df474: codified standards, tooling fixes, every node re-verified #45. GitHub did not retarget Sync lgse/strata#1912, #1885: remappable per-map keys, uncomposited popovers, typed-path preview #47, so merging it as is would land inresync/full-audit, notmain. Retarget Sync lgse/strata#1912, #1885: remappable per-map keys, uncomposited popovers, typed-path preview #47 tomainbefore merging it, then retarget this PR tomain.mainwas last changed by Full resync at lgse/strata 86df474: codified standards, tooling fixes, every node re-verified #45. I setreview: reviewedon 105 of them in a separate commit (dc3117d), changing nothing else.browser/context-menu,browser/view-modes,browser/view-modes/list/column-layout,browser/view-modes/position-restoreoperations/clipboard/send-to,operations/delete,operations/delete/dissolve,operations/trashpreview/preview-panel/documents,preview/preview-panel/find,preview/preview-panel/layout,preview/preview-panel/pdfsettings/themes/icons/catppuccindraftlater in this PR, because this sync changed their content.driftandqa --prhit the REST pagination bug Sync lgse/strata#1912, #1885: remappable per-map keys, uncomposited popovers, typed-path preview #47 reports:--paginatefollows arepositories/<id>/…link, and the proxy refuses it.page=N.data/prs.jsonlrows are not committed.checkreports 0 errors and 25 warnings. The warnings are the existing ones saying the site is at v1.0.0 while v1.1.1 is out. All 48 unit tests pass.Upstream range
73b3258ff9da7fd5f8b279e442e4fbf576850deb(#47's watermark) →44bfeab305cfb68993bafcf4794fe0bbf7ff1433: 4 commits, 4 PRs, no direct pushes. Every touched node and sweep is reviewed at44bfeab.app/updatessettings/preferences/language(drift)browser/navigation/administrator-accessapp/updates, for theSTRATA_UPDATER=disabledswitch.app/updates,app/updates/install).current/themeswitch →settings/themes, which ownstheme.rs. The Behavior is onomarchy.browser/sidebar.remote/file-providers/network-locations.app/updates.settings/preferences, which owns the hidden-files toggle, its QA scenario, anddocs/preferences.md. The Behavior is onbrowser/directory-monitoring.g +flash waits for the bookmark save →integration/10xer-mode/places.browser/navigation/location-bar.browser/view-modes/density.Per node
New
browser/navigation/administrator-access: origin{issue: lgse/strata#1836, pr: lgse/strata#1837}, shipped, draft.code: []: every implementing file is a sweep trigger or belongs toapp/infrastructure.tests: [src/app/browser/tests/administrator.rs],docs: [docs/administrator-access.md].access(2), so ACLs count)admin://, with percent-escapingadminadmin:///admin://mount can't be unmounted (#1837).site/unguided.yaml.app
app/updates: rows for #1909 and #1934.code+=src/ui/settings/update_status.rs(new in #1909).docs+=docs/packaging.md, which I removed from the childpackage-managed, since children inheritdocs.STRATA_UPDATERvalues are accepted or rejected.app/updates/install: Design line saying a disabled build refuses installs (#1934,docs/packaging.md).app/dialogs: the Open as Administrator error dialog focuses its button, and its cancel button reads Close (#1837).app/accessibility: "Folder that requires administrator access" and the folder-link variant (#1837).app/packaging: the desktop entry hashu(#1918).app/packaging/installer:hu*locales get Hungarian messages (#1918).reviewed_atonly:infrastructure,window,window/key-dispatch,keyboard-shortcuts/remapping.browser
navigation: the unreadable-folder dialog bullet is now limited to Columns, for folders not yet marked or where GIO lacksadmin(#1807, #1837, unverified). The Summary names the new child.navigation/location-bar: #1909 row.adminis now an accepted scheme.sidebar: #1909 row. Place rows use a neutral hover tint. The #1862 gap is dropped.view-modes/density: #1909 row. The buttons sit at least 8 px apart with reserved width, and zh-TW "Airy" reads 寬鬆. The gap is dropped.directory-monitoring:admin://rows can prompt after the grant expires. l0gicgate's review on #1837 is the only source.context-menu: Open With hidden; Permanently delete instead of Move to Trash.view-modes: pane button and notice.view-modes/columns: column button; notice on the root column only.selection/keyboard-navigation: Tab order Open as Administrator → Retry.thumbnails: no admin thumbnails; in-place lock icon; custom icons kept.tabs/session-restore: admin tabs skipped (#1836, #1837).sidebar/pins/drag-to-pin:testsnarrowed from thesidebar_pinningfolder to 4 explicit files.tenxer-pin-feedback-identifies-slot.jsonl(new in #1909) goes tointegration/10xer-mode/places.reviewed_atonly: the other drift-listed browser nodes.integration
10xer-mode/places: #1909 row.g +flash waits for the save and names slot g 1–g 9.tests.10xer-mode/file-verbs:din an admin folder opens the permanent confirmation (#1837).Owith an admin target refuses with a flash (unverified).open-with: activating a file in an admin folder shows "Unable to open item" with the refusal, plus a Design bullet (#1836, #1837).portal-file-chooser: an unreadable folder never offers Open as Administrator (#1837).relatednow links the new node.operations
trash:admin:, so admin items get the local wording.undo: copies (including Replace), New Folder, and New File into an admin folder record no entry and keep the redo history. Rename and moves still record (#1837).clipboard/conflicts: in an admin folder:reviewed_atonly:archives,clipboard,delete/dissolve,trash/animation.settings
preferences/language: #1918 row.hu_HU, Hungarian digit grouping and durations.preferences: #1909 fix-5 row and Design bullet.preferences/date-format: Hungarian Long date and weekday (#1918).diagnostics: in a disabled build with no install marker, Installation reads "In-app updates are disabled in this build."; with a marker, it reads the marker's ownership (unverified) (#1934).themes: #1909 fix-1 row. The link-chain gap now names custom theme files only (#1887).themes/omarchy: editingcolors.tomlafter acurrent/themeswitch re-applies the palette (#1909), plus a Design bullet. An inner-link repoint does not reload (unverified; see Bugs).reviewed_atonly:icons,icons/catppuccin.remote
file-providers/network-locations: #1909 row.file-providers/kde-connect,localsend: provider messages in Hungarian underhu_HU(#1918).devices and preview
devices/volumes: device rows share the neutral hover (#1909, the 6% figure unverified). The rows are built insrc/ui/window.rs, an app trigger, so the bullet goes on the feature it serves.preview/quick-preview/folder-peek: a peek of an unreadable folder shows no Open as Administrator (#1837, unverified). This is an ownership fix:peek.rspasses no admin button. The bullet first sat on the new node.reviewed_atonly:devices/volumes/camera,preview/preview-paneland itslayout,model-views, androuteschildren.scopes.yamlis unchanged.QA
All 8 sweeps are touched, and each has
reviewed_at: 44bfeab.STRATA_UPDATERvalues; updates in a disabled build, a stalled startup check, Check now with a failing proxy, install plus check plus cancel; dialogs; locked-folder accessibility with ACLs;hu_HUlauncher and installer. Setup adds a disabled build.### browser/navigation/administrator-accesssectionadmin:///rootsession restoreg +with a read-only bookmarks file,Oand activation in admin folders.triggers+=data/locales/hu.json.browsertenxer-pin-feedback-identifies-slot, now on placesqa --pr N --tier 1). None has "Unmapped changes".app/infrastructure,app/updates/install,location-bar/completion,delete/dissolve,trash/animation,settings/diagnostics,settings/preferences. Sweeps: app, browser, operations, settings (triggerdata/locales/messages/**).services/file_source.rs).data/locales/hu.json.Needs a person
network-locations. Most of its lines are inservices/file_source.rs(unowned) andlocal_files.rs(app/infrastructure).location-bar. Its lines are inlocation.rs(app/infrastructure) andui/browser.rs(trigger).settings/preferences, with its Behavior ondirectory-monitoring.src/ui/browser/entry.rsis still onsettings/themes/icons/catppuccin(Full resync at lgse/strata 86df474: codified standards, tooling fixes, every node re-verified #45 item). It now also picks the admin lock icon and triggers thelistablefill. The marking bullet sits onadministrator-access.browser/navigation/administrator-accesshascode: []. Future admin-only PRs will map toapp/infrastructureor triggers, so writers must route them here by hand.zh-TW.jsonhit existing settings triggers;hu.jsonwas added as a trigger.(unverified)claims added: 33. List them withgit diff origin/claude/friendly-cray-rvlc98...HEAD -- features | grep '^+' | grep '(unverified)'.Bugs and upstream doc contradictions
None was filed upstream. Issue search (
search/issues) is blocked in this session. Instead, the research agents listed the 600 newest lgse/strata issues and PRs and checked titles and bodies; none covers these.STRATA_UPDATER=disabledbuild's Diagnostics "Update server" check still contactsapi.github.com/rate_limit.src/services/diagnostics.rs:431-433,800-805; noupdater_enabled()gate.(unverified)onsettings/diagnostics.current/themepoints to a folder that is itself a link, repointing that inner link does not reload the palette.src/ui/theme.rs:1171-1180watches only the canonical target and the state folder's ancestors.(unverified)onsettings/themes/omarchy.admin://rows go through GIO and can raise an unasked polkit prompt after the grant expires (l0gicgate on #1837). Recorded as a gap onbrowser/directory-monitoring.app/updates.44bfeab:docs/remote-sftp.md:48-49still says backend text reaches the dialog with user info stripped. Since #1909, URI locations show translated text instead.Site pages made stale (for the next release docs run; not edited)
reference/remote-sftp.md:149-151: backend error text (#1909).guide/settings.md: "11 languages" (now 13, #1918), the Updates page in builds without the updater (#1934), and Diagnostics Installation.reference/signed-updates.mdandguide/install.md: theSTRATA_UPDATER=disabledbuild switch (#1934).guide/views.mdandreference/keyboard-navigation.md: Open as Administrator, the lock icon, and the admin notice (#1837).guide/operations.md: Trash, Undo, and Replace in admin folders (#1837).guide/10xer.mdandreference/10xer-mode.md:dandOin admin folders (#1837);g +slot feedback (#1909).guide/themes.md: sidebar hover and Follow Omarchy symlink switches (#1909).Review loop
Three rounds, each with one fresh adversarial reviewer per area group: app (+devices), browser, integration+operations, settings+remote. A fresh verifier checked every blocking finding before any fix. No finding was refuted.
STRATA_UPDATERbullets were onapp/infrastructure; moved toapp/updatesundonavigationdevices, and long sentences.diagnosticsnaming pacman ownership instead of the install markernetwork-locationsreview: drafton a front-matter-only nodeapp/dialogspreview/quick-preview/folder-peek. All round-3 minors were applied, except the ones listed below.settings/preferences(#1909 hidden entries) andsettings/preferences/language(network-location pointer) partly repeat Design on the nodes that own the code. Both are sourced.(unverified)Update server bullet ondiagnosticscites #1934, which did not change that path.Generated by Claude Code