Repository navigation
refactor: remove leftover electron adapters and unused scripts - #571
Merged
Merged
Conversation
delete the uncalled core lan stdio bridge, hidden desktop-profile command, orphan markdown probe, and two unreferenced helper files. Co-authored-by: redial.solute_1r <redial.solute_1r@icloud.com>
This was referenced Nov 13, 2026
Contributor
Author
There was a problem hiding this comment.
本轮验收通过,但不能自我批准,也不能压缩合并受保护的 main。
对照 main @ 64562374 新建。--desktop-client-bridge、CLI DesktopProfile / prepare_profile、markdown-performance.ts、ci-runner-load.sh、private-control.d.mts 无仓库内调用方。crates/client 仍依赖 vibeface-secure-ffi。
本轮验证:cargo +1.91.0 check -p vibeface-core --locked --bins 通过;cargo +1.91.0 test -p vibeface --locked canonical_profile 通过。未改数据库、schema 或 DATA_EPOCH。开发分支 PR 不跑 GitHub Actions。
请维护者 squash merge。不要再开重复的 Electron 死路径 PR。#553 应在本 PR 合入后关闭。
Sent by Cursor Automation: Vibeface 清理
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


问题
#544 把桌面迁到 GPUI 之后,Core 仍保留无人调用的
--desktop-client-bridgestdio LAN 适配,CLI 仍有隐藏的desktop-profile(只服务已删除的 Electron 主进程),状态机文档还指向不存在的apps/desktop/src/main/*.ts。#553 做过同一组删除,但基线停在旧 main,Cargo.lock已过时。改动
apps/core/src/desktop_client_bridge.rs及 Core 对vibeface-secure-ffi的依赖。GPUI 客户端在进程内lan_connect,不再 spawn Core 做 stdio 桥。crates/client仍依赖 FFI。DesktopProfile和仅被它使用的 CLIprepare_profile。档案目录改由apps/desktop/src/host创建;desktop-node仍要求已有私有目录。canonical_profile拒绝非私有目录的测试。state-machines.md、gpui-desktop.md中过时的 Electron /crates/control/src/client.rs表述。markdown-performance.ts、scripts/ci-runner-load.sh、scripts/private-control.d.mts(windows-signing.mjs仍 importprivate-control.mjs)。没有改协议、存储、schema 或
DATA_EPOCH。不和 #479 TextDecoder、#483 聊天缓存、#551 付费 UI 测试、#562 更新发现、#472 CI 结构重叠。#553 被本 PR 从当前 main 重做,请合入本 PR 后关闭 #553。验证
cargo +1.91.0 check -p vibeface-core --locked --bins通过。cargo +1.91.0 test -p vibeface --locked canonical_profile通过。开发分支 PR 不跑 GitHub Actions。未改数据库。本环境 token 不能向受保护的
main压缩合并。