Repository navigation
Conversation
The updater downloaded every page of the release listing before choosing a version. Each product release now attaches about 45 assets, so the first page already returns 2.2 MiB and would pass the 4 MiB response limit after about 30 more product releases, failing every check and apply. List the product tag refs instead (one small response), keep the channel's tags newer than the running version in numeric order, and fetch only those releases, newest first. A missing or draft release answers 404 and is skipped; everything after that keeps the existing verification. Probing is capped at 16 candidates and reports an error instead of 'no update' when none of them is complete.
install.sh and install.ps1 read every page of the release listing with the same 4 MiB page limit as the updater, so they would stop installing at the same point. Both now list the product tag refs, order the channel's tags by version and look up those releases one at a time, newest first. A release that is missing, a draft or carries the wrong prerelease flag is skipped before its completion manifest is read; a lookup that answers for another tag fails. At most 16 candidates are looked up. The self-tests cover tag-ref parsing (including refs outside refs/tags and unsafe names), the three skip cases, the tag mismatch and the lookup bound on both sides of 16; the pagination-only cases are removed. The release notes describe the new discovery.
shellcheck reports SC2016 for the literal $(id) test input. A semicolon is rejected by the same character check without looking like an expansion.
…ew test The test added in #556 passes /tmp/original.json to --recovery-file, which must be absolute. That path is not absolute on Windows, so the first parse fails there and the Windows CLI scope has been red on main; the two expected-error assertions also passed on Windows for the wrong reason. Build both paths from the temp directory, as the neighbouring test does.
Two sets of size bounds are about to be outgrown by the packages they check. The npm package bundles all four platform packages and is verified in collect with a 512 MiB decompression bound and a 384 MiB compressed bound. 0.0.1-nightly.20261112.3 is already 491.6 MB unpacked and 175 MB packed, after 216 MB on 2026-11-06. Once collect fails on the bound, publish-product never writes release.json, so no installer or updater sees the release and the Nightly coordinator stops. Raise the bounds to 2 GiB unpacked and 1 GiB packed, shared by both checks. The updater and both installers refuse platform archives over 128 MiB and packages over 512 MiB unpacked. The largest archive is 42.9 MiB today and grew 1.3-2.7 MiB a day, so it would pass the bound in one to two months. That limit locks itself: an installed updater can never download the release that raises it. Raise it to 1 GiB packed and 2 GiB unpacked now, while nodes can still take the update.
There was a problem hiding this comment.
Stale comment
本轮不合并。
对照
main@64562374:Ready,但 CONFLICTING。冲突落在apps/cli/src/update/release.rs、install.sh、packages/docs/releasing.md、scripts/install.ps1。#566 小时发布和后续发布路径改动之后,发现逻辑需要按当前 main 重做。描述里 Core CI 属于
fbc67da8。当前 head6c15e67e的ci-gate、Linux x64 包验收和 Desktop acceptance gate 失败,不能当作已验收。上限放宽是产品取舍,冲突未解前不自动合。清理轮次不代 rebase,也不另开 updater discovery PR。Sent by Cursor Automation: Vibeface 清理
There was a problem hiding this comment.
Stale comment
本轮不合并。
Ready,但对照
main@07191092为 CONFLICTING。冲突落在apps/cli/src/update/release.rs、install.sh、scripts/install.ps1和packages/docs/releasing.md。描述里的 Core CI 属于旧提交fbc67da8,当前 head6c15e67e的检查不能再当作通过。发现路径改动仍有价值,但冲突未解前不代 rebase,也不另开 updater listing / install.sh discovery PR。请作者从当前 main 重做并用当前 head 重验收。等下一轮。
Sent by Cursor Automation: Vibeface 清理


Problem
The updater (
vibeface update check/apply),install.shandinstall.ps1all download every page ofGET /repos/leaperone/vibeface/releases?per_page=100before choosing a version, and each page must fit in 4 MiB. Every product release now attaches about 45 assets, and the listing embeds each asset with its uploader, so a modern product release is about 81 KB of listing JSON.Measured on 2026-11-13: page 1 is 2.16 MiB (100 releases, 1144 assets). Replaying new product releases on top of it, page 1 passes 4 MiB after about 29–32 more product releases (steady state would be 7.7 MiB per page). From then on every check, apply and install fails with
release response exceeds limiton both channels, because the listing is read in full before filtering. At the scheduled Nightly cadence that is days, not months.Change
Discovery reads tag refs instead of the release listing. Everything after choosing a candidate is unchanged.
GET /git/matching-refs/tags/vreturns every product tag in one unpaginated response (106 tags, 49 KB today; nodejs/node returns 975 tags in one response the same way).GET /releases/tags/{tag}newest first. 404 means a draft or a tag whose release does not exist yet, and is skipped. A response for a different tag fails. Draft or wrong-prerelease releases are skipped, as before.release.json, tag commit, asset size and digest checks run on that single release object, exactly as they did on the listing entry.API calls per check stay the same (refs + one release, instead of two listing pages). Downloaded JSON drops from about 2.6 MB to about 130 KB.
Files:
apps/cli/src/update/release.rs:checkand the purecandidate_tags.get_optional_jsonreuses the 404-aware download; the manifest keeps its own error context.install.sh: a strictrefsmode injson_fields(the value must start withrefs/tags/, and the remainder passes the existing character check), tag-onlyselect_release, the per-release lookup, and a sharedfetch_optional. The pagination-onlyreleasesmode is removed.scripts/install.ps1: the same flow.Select-Releasetakes tags;Get-OptionalDownloadgains a label;Get-OptionalJsonis added.packages/docs/releasing.md: the update-channel and first-install sections describe the discovery.Also in this PR:
apps/cli/src/manage.rs(test only):recovery_review_needs_no_replacement_file_and_keeps_selection_explicit, added in feat(cli): add a complete client for Bots and Core operations #556, passes/tmp/original.jsonto--recovery-file, which must be absolute. That path is not absolute on Windows, so CI / Windows native has been red on main since feat(cli): add a complete client for Bots and Core operations #556. It also skippedwindows packaged processes, the only job that runsinstall.ps1 -SelfTest. Both paths are now built fromstd::env::temp_dir(), as the neighbouring test does. This also makes the two expected-error assertions fail for the reason they test, not because of the path.scripts/package-npm.mjs,apps/cli/src/update/release.rs,install.sh,scripts/install.ps1). Two sets of bounds are about to be outgrown:collectagainst a 512 MiB unpacked and 384 MiB packed bound.0.0.1-nightly.20261112.3is already 491.6 MB unpacked and 175 MB packed; it was 216 MB on 11-06. Whencollectfails,publish-productnever writesrelease.json, so no installer or updater sees the release and the Nightly coordinator stops. The bounds are now 2 GiB unpacked and 1 GiB packed, shared by both checks.vibeface-coreis 95 MiB, of which 23 MiB is symbol tables), or not gating Nightly completion on npm.install.sh: the unsafe tag-ref test input no longer contains$(...), which shellcheck flagged as SC2016.Validation
cargo fmt --all -- --check,cargo clippy -p vibeface --all-targets --locked -- -D warnings,python3 scripts/ci.py test --tier fast --packages vibeface(113 passed). New unit test:candidate_tags_keep_newer_channel_tags_in_version_order.20261110.4come out as.3 > .2 > .1.v0.0.1-nightly.20261112.3resolves to source8a06a332..2(norelease.json) is skipped;v0.0.1-nightly.20261031.16(tag without a release) is a 404 and skipped.check(nightly)from the current build reports no newer release;check(stable)reports no release.bash -n install.sh,bash install.sh --self-test. New cases:refs/heads/*, a craftedrefs/abcdev1.0.0,$(...),..and nested paths;Mutation check: disabling the draft/prerelease check, the bound, the
refs/tags/prefix check or the tag-mismatch check each makes the self-test fail.install.sh --channel nightlyinto a temporary root installs0.0.1-nightly.20261112.3(8a06a332, x86_64 Linux);--channel stablefails with "no published Stable release".node --check scripts/package-npm.mjsandnode scripts/package-npm.mjs --self-testpass with the new bounds.shellcheck,actionlintand the www portal build (tools not installed here), andinstall.ps1 -SelfTest, which only runs under Windows PowerShell 5.1 inverify-windows-node.py. Remote: CI / Core passed onfbc67da8(22/22, including shellcheck, actionlint and the installer self-test); CI / Windows nativewindows rust (cli)passes with the test fix. Thepackaged processesjob, which runsinstall.ps1 -SelfTest, only runs with a package artifact, so CI / Desktopfull-validationis dispatched on the final head. The first round failed on shellcheck SC2016 in the new test (fixed) and on the Windows CLI failure above, which comes from main.Not in this PR
Other update and release findings from the same investigation (desktop self-update, updater on hosts without a systemd user bus, Nightly coordinator robustness) are reported separately. The arm64 desktop release failure is handled by #561.