feat: refresh app shell navigation#95
Closed
lan17 wants to merge 1 commit into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
=======================================
Coverage 87.16% 87.16%
=======================================
Files 151 151
Lines 16422 16422
=======================================
Hits 14314 14314
Misses 2108 2108 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced May 9, 2026
Owner
Author
lan17
added a commit
that referenced
this pull request
May 9, 2026
## Stack Collapse - This PR is now the single M1 UI/UX refresh PR targeting `main`. - It supersedes the earlier stacked PRs: #95, #96, #97, #98, #99, #100, #101, #102, and #103. - Those PRs are closed to keep review focused here. ## Tickets - App shell, navigation, and route cleanup: https://www.notion.so/35ad8336c59f8161bfacdcde283f4dfe - Shared UI primitives and responsive scaffolding: https://www.notion.so/35bd8336c59f81f3b6ffd66b97bf90d1 - Live page camera cards: https://www.notion.so/35ad8336c59f81f3ba21e04df831f83b - Push-to-talk primary camera action: https://www.notion.so/35ad8336c59f81f09281dcc6779ad64b - Events card/list view: https://www.notion.so/35ad8336c59f81ddb0b1e0c5d6e705b9 - Event detail cleanup and client-side previous/next: https://www.notion.so/35ad8336c59f81b0b931c47c77cc489f - Quick filters and advanced drawer: https://www.notion.so/35ad8336c59f814589bce2243ba18a2e - Mobile hardening pass: https://www.notion.so/35ad8336c59f811cb1b4e22a3fd0bb59 - Settings/System split: https://www.notion.so/35ad8336c59f81199ba0f8bb28d0f955 - Basic camera health: https://www.notion.so/35ad8336c59f81d3aa1ef147f741bb94 - Visual polish, copy cleanup, and basic page states: https://www.notion.so/35ad8336c59f81568085d9f6ee5304b8 ## Scope - Makes Live the day-to-day camera surface and keeps camera setup under Settings. - Removes Cameras from desktop and mobile primary navigation. - Redirects the old `/cameras` route to `/settings/cameras` for backward compatibility. - Adds push-to-talk to Live camera cards using the existing talk UI/hooks/APIs. - Keeps mobile Live focused on one active camera by default. - Replaces table-first/event-admin surfaces with card/list/detail hierarchy, quick filters, technical disclosures, and homeowner-readable labels. - Keeps Camera as an always-visible Events filter using the existing `camera` query param. - Plays event video inline in the Events list using the existing clip media URL/token flow, with inline Details expansion for metadata. - Keeps `/events/:clipId` available for backward-compatible deep links, but normal list review no longer requires opening a separate detail page. - Splits homeowner Settings from System diagnostics and uses existing camera health fields only. - Polishes the app shell, Live cards, event cards, preview/talk copy, badges, empty states, and responsive spacing. ## UI Notes - Local render review was run against mocked existing APIs for camera list/status/preview/talk, health, setup status, clips, and clip media. - Checked desktop and mobile render paths in the browser; no horizontal overflow at 1280px or 390px. - Re-checked Events at desktop width after the inline video change; playable video controls render in the list and Details expands in place without clipping badges/actions. - Re-checked Events at 390px mobile width after the filter fix; Camera is visible, More filters opens inline, and horizontal overflow is zero. - Live now shows preview and push-to-talk together; Camera setup is reachable from Settings and from camera card settings actions. - Technical/source/backend details stay behind disclosures or in System/Settings surfaces. ## Self-Review Notes - Re-reviewed the diff after the corrective pass for backend/API additions and found none. - Verified `/cameras` no longer competes with Live as a primary user-facing page. - Verified Live camera cards pass `showTalkControl` and keep compact mobile behavior. - Verified Events list uses existing `useClipMediaUrl`/media-token behavior and does not add thumbnails, event-neighbor APIs, review state, or feedback APIs. - Verified Camera filter maps to the existing URL-synced `camera` clip query param. - Confirmed no new review state, event feedback, thumbnails, health reason codes, live summary, or event-neighbor behavior was added. - Left unrelated dirty `graphify-out` wiki files unstaged. ## Checks - `pnpm --dir ui exec vitest run src/app/layout/AppShell.test.tsx src/routes/AppRouter.test.tsx src/features/live/LivePage.test.tsx src/features/cameras/components/CameraPreviewPanel.test.tsx src/features/settings/SettingsPage.test.tsx src/components/ui/primitives.test.tsx` - `pnpm --dir ui test -- ClipsPage.test.tsx` - `pnpm --dir ui check` - `TEST_DB_DSN=postgresql://homesec:homesec@localhost:55432/homesec make check` - Browser render review with local Vite app and mocked existing API responses. ## Backend Scope - No backend routes, schema changes, persistence changes, notification behavior, alert review state, event feedback APIs, backend thumbnails, live-summary endpoints, event-neighbor endpoints, enriched camera-health reason codes, or new media APIs were added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://www.notion.so/35ad8336c59f8161bfacdcde283f4dfe
Scope
/systemand makes/land on/live./eventsas the user-facing clips list/detail route while preserving/clipsand/clips/:clipIdredirects, including existing filter/search context./settingslanding surface that points to the existing setup/config surfaces and keeps System under Advanced.UI Notes
/redirects to/live.Self-review notes
graphify-out/wiki/*modifications unstaged and out of this PR.Checks
pnpm --dir ui install --frozen-lockfilepnpm --dir ui exec vitest run src/app/layout/AppShell.test.tsx src/routes/AppRouter.test.tsx src/features/system/SystemPage.test.tsx src/features/setup/SetupWizardShell.test.tsx src/features/setup/steps/WelcomeStep.test.tsx src/features/setup/steps/ReviewStep.test.tsxpnpm --dir ui typecheckmake ui-checkNote:
make ui-checkpassed. Vite emitted the existing local Node warning because this machine has Node 20.11.0 while Vite wants 20.19+ or 22.12+, but the production build completed successfully. The Vite dev server does not start on Node 20.11.0 due tocrypto.hash; browser smoke used the builtui/distoutput served locally instead.Backend changes
None. This is frontend-only and uses existing APIs/data only.
Stack
First PR in the M1 UI refresh stack. PR 2 should be stacked on
codex/m1-app-shell.