Skip to content

feat: polish M1 home security UI#104

Merged
lan17 merged 13 commits into
mainfrom
codex/m1-visual-polish
May 9, 2026
Merged

feat: polish M1 home security UI#104
lan17 merged 13 commits into
mainfrom
codex/m1-visual-polish

Conversation

@lan17
Copy link
Copy Markdown
Owner

@lan17 lan17 commented May 9, 2026

Stack Collapse

Tickets

Scope

  • Makes Live the day-to-day camera surface and keeps camera setup under Settings.
  • Removes Cameras from desktop and mobile primary navigation.
  • Redirects the old /cameras route to /settings/cameras for backward compatibility.
  • Adds push-to-talk to Live camera cards using the existing talk UI/hooks/APIs.
  • Keeps mobile Live focused on one active camera by default.
  • Replaces table-first/event-admin surfaces with card/list/detail hierarchy, quick filters, technical disclosures, and homeowner-readable labels.
  • Keeps Camera as an always-visible Events filter using the existing camera query param.
  • Plays event video inline in the Events list using the existing clip media URL/token flow, with inline Details expansion for metadata.
  • Keeps /events/:clipId available for backward-compatible deep links, but normal list review no longer requires opening a separate detail page.
  • Splits homeowner Settings from System diagnostics and uses existing camera health fields only.
  • Polishes the app shell, Live cards, event cards, preview/talk copy, badges, empty states, and responsive spacing.

UI Notes

  • Local render review was run against mocked existing APIs for camera list/status/preview/talk, health, setup status, clips, and clip media.
  • Checked desktop and mobile render paths in the browser; no horizontal overflow at 1280px or 390px.
  • Re-checked Events at desktop width after the inline video change; playable video controls render in the list and Details expands in place without clipping badges/actions.
  • Re-checked Events at 390px mobile width after the filter fix; Camera is visible, More filters opens inline, and horizontal overflow is zero.
  • Live now shows preview and push-to-talk together; Camera setup is reachable from Settings and from camera card settings actions.
  • Technical/source/backend details stay behind disclosures or in System/Settings surfaces.

Self-Review Notes

  • Re-reviewed the diff after the corrective pass for backend/API additions and found none.
  • Verified /cameras no longer competes with Live as a primary user-facing page.
  • Verified Live camera cards pass showTalkControl and keep compact mobile behavior.
  • Verified Events list uses existing useClipMediaUrl/media-token behavior and does not add thumbnails, event-neighbor APIs, review state, or feedback APIs.
  • Verified Camera filter maps to the existing URL-synced camera clip query param.
  • Confirmed no new review state, event feedback, thumbnails, health reason codes, live summary, or event-neighbor behavior was added.
  • Left unrelated dirty graphify-out wiki files unstaged.

Checks

  • pnpm --dir ui exec vitest run src/app/layout/AppShell.test.tsx src/routes/AppRouter.test.tsx src/features/live/LivePage.test.tsx src/features/cameras/components/CameraPreviewPanel.test.tsx src/features/settings/SettingsPage.test.tsx src/components/ui/primitives.test.tsx
  • pnpm --dir ui test -- ClipsPage.test.tsx
  • pnpm --dir ui check
  • TEST_DB_DSN=postgresql://homesec:homesec@localhost:55432/homesec make check
  • Browser render review with local Vite app and mocked existing API responses.

Backend Scope

  • No backend routes, schema changes, persistence changes, notification behavior, alert review state, event feedback APIs, backend thumbnails, live-summary endpoints, event-neighbor endpoints, enriched camera-health reason codes, or new media APIs were added.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.16%. Comparing base (60a76e7) to head (eb8cc31).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #104   +/-   ##
=======================================
  Coverage   87.16%   87.16%           
=======================================
  Files         151      151           
  Lines       16422    16422           
=======================================
  Hits        14314    14314           
  Misses       2108     2108           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lan17 lan17 merged commit 31a0fff into main May 9, 2026
5 checks passed
@lan17 lan17 deleted the codex/m1-visual-polish branch May 9, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant