fix(display): constrain graphic logo height, normalize audio, and wrap lines to terminal width - #186
Merged
Merged
Conversation
Assisted-By: Gemini 3.6 Flash
… to full terminal width Assisted-By: Gemini 3.6 Flash
Assisted-By: Gemini 3.6 Flash
…_win_audio_device Assisted-By: Gemini 3.6 Flash
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes graphic logo size, audio device noise, and line wrapping: 1. Constrained Kitty, iTerm2, Sixel, and Chafa graphic logos to max 10 terminal rows high (~26 columns wide) in src/logo.rs and src/display.rs. 2. Added normalize_win_audio_device in crates/sysinfo/src/audio.rs to filter virtual kernel streaming proxy drivers and normalize/deduplicate internal sub-endpoint names to clean physical hardware controllers. 3. Differentiated line wrap width in src/display.rs: beside-logo lines (0..logo_height) wrap to text_column_width - 2, while below-logo lines wrap to term_width - 2 (full terminal width). 4. Enhanced wrap_info_line in src/display.rs to split at logical boundaries (comma-separated lists) and keep atomic pairs (such as RX: ... TX: ...) intact on the same line.