ci: disable Claude Code Review workflow - #187
Merged
Merged
Conversation
The claude-review job no longer runs on pull requests: the `pull_request` trigger is replaced with `workflow_dispatch` and the job carries `if: false`, so it is off by default but can still be invoked manually if wanted. Bumps retch-cli 0.6.16 -> 0.6.17 (patch), refreshes Cargo.lock, regenerates docs/retch.1 for the new version footer, and updates the NOTES.md Current State header and release log. Assisted-By: Claude Opus 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Turns off the
Claude Code ReviewGitHub Actions workflow for pull requests:pull_requesttrigger (opened,synchronize,ready_for_review,reopened) is commented out and replaced withworkflow_dispatch, so the workflow still exists and can be started by hand;claude-reviewjob additionally carriesif: false, so even a manual dispatch is a no-op until that guard is removed.Two independent switches rather than one, so re-enabling is a deliberate act and neither half can silently turn the review back on.
Why
The automated review ran on every PR and every subsequent push, adding a required-looking check and API cost without changing review outcomes on this repo — the
just prgate plus the 15-job CI matrix already cover the ground it was reporting on. Disabling in place (rather than deleting the file) keeps the wiring intact for a future opt-in.Also in this PR
Standard per-PR hygiene from
AGENTS.md§4:retch-cli0.6.16 → 0.6.17 (patch),Cargo.lockrefreshed viacargo checkdocs/retch.1regenerated withjust man(version footer only — one line)NOTES.mdCurrent Stateheader bumped and a release-log entry addedRelease note for tagging:
v0.6.16was tagged at622cf3b(#184), but #185 and #186 merged afterwards withCargo.tomlstill reading0.6.16. Sov0.6.17rolls up three changes — #185 (portable Justfile recipes), #186 (logo height / audio normalisation / line wrapping) and this chore — and it is a two-crate publish, sinceretch-sysinfo 0.1.52is not on crates.io yet (the index has0.1.51).Skipped deliberately, each a legitimate no-op for a CI-only change:
README.md(no user-visible flag, config key, or feature), the GitHub wiki (all 8 pages checked — none documents the workflow list), anddocs/retch.md/ tldr (no CLI flags changed).Test plan
just prgate green end to end: version-bump check,NOTES.mdheader check,just manregen matches the committed page,cargo checkleavesCargo.lockcleanjust check—cargo fmt --check,cargo clippy --workspace -- -D warnings, andcargo clippy --features graphics -- -D warningscargo test --workspace— 59 cli + 15 integration + 115 sysinfo, all greencargo audit— no new advisories (only the pre-existing allowedpasteRUSTSEC-2024-0436 unmaintained warning)claude-code-review.ymlparses as YAML, exposes exactly one trigger (workflow_dispatch), and itsclaude-reviewjob resolvesif: falseclaude-reviewcheck appears on this PR — the point of the change; verified on this PR:gh pr checks 187lists 17 checks (CodeQL x3, audit, aur, 7x build, graphics-feature, full-test/build-release/release/nixpkgs skipping) and zeroclaude-reviewentriesgh workflow run "Claude Code Review"is registered on the default branch) — cannot be verified pre-merge, sinceworkflow_dispatchis only offered from the default branch's copy of the file