Repository navigation
chore: maintenance round for v0.12.2 (deps, go 1.26.8, #90 fixes) - #116
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…90) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
- make the directory fsync in AtomicWrite best effort so filesystems that refuse it do not turn a completed write into an error - leave DETAIL when a result with no rows arrives - document that insertCompletion needs a focused textarea Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 903b900a87
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| m.applyResult(msg.result) | ||
| m.resetResultOverlays() |
There was a problem hiding this comment.
When a query finishes while STATS is open, or while DETAIL is open and the new result is empty, applyResult calls syncViewport before resetResultOverlays changes the mode. The viewport is therefore rebuilt and cached with lastHighlight=false; after the mode becomes NORMAL, the selected-column highlight remains missing until another input or resize triggers synchronization. Reset the overlay mode before applying the result, or synchronize again after the reset.
AGENTS.md reference: AGENTS.md:L11-L11
Useful? React with 👍 / 👎.
- Reset the STATS/DETAIL overlays before applying a new query result, so the viewport rebuild sees NORMAL mode and draws the column-header highlight instead of caching lastHighlight=false until the next input. - Assert lastHighlight in the two overlay-reset tests (both fail without the reorder). Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
1 participant
Summary
Notes
Test plan
🤖 Generated with Claude Code