Repository navigation
fix(ui): keep the header highlight when a result closes STATS/DETAIL - #117
Merged
Merged
Conversation
- Reset the STATS/DETAIL overlays before applying a new query result, so the viewport rebuild sees NORMAL mode and draws the column-header highlight instead of caching lastHighlight=false until the next input. - Assert lastHighlight in the two overlay-reset tests (both fail without the reorder). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kwrkb
added a commit
that referenced
this pull request
Sep 30, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the Codex review comment on #116 (merged).
When a query finished while STATS was open, or while DETAIL was open and the new result was empty,
applyResultrebuilt the viewport beforeresetResultOverlaysswitched the mode back to NORMAL. The rebuild cachedlastHighlight=false, so the selected-column header highlight stayed missing until another key or resize.resetResultOverlaysbeforeapplyResult(it readsm.lastResult, which is already set to the new result).TestNewResultResetsStatsAndDetail/TestEmptyResultLeavesDetailModenow assertlastHighlight; both fail without the reorder.go vet ./...andgo test ./...pass.🤖 Generated with Claude Code