fusion: keep only apiVersion, kind and metadata in values.yaml#174
Merged
Conversation
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
For fusion charts, trim each resource entry in the generated values.yaml to only the apiVersion, kind and metadata fields. The remaining fields are sourced from the resource's schema defaults. Signed-off-by: Tamal Saha <tamal@appscode.com>
tamalsaha
force-pushed
the
fusion-values-minimal-fields
branch
from
2b8b65d to
810783f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
For fusion charts, trim each resource entry in the generated
values.yamlso it keeps only theapiVersion,kindandmetadatafields.Why
The remaining resource fields (e.g.
spec) are sourced from the resource's schema defaults, so they don't need to be duplicated in the chart'svalues.yaml. This keeps the generated values minimal.Notes
resourceValues(and hence written tovalues.yaml). The fullcpobject is left intact, since it's reused immediately afterward for schema generation (GVR lookup and theHelmRelease→ schema conversion, including chart-version resolution).metadataretains its existing minimal shape (name,namespace, pluslabelsforHelmReleaseresources).