fusion: keep full HelmRelease object in values.yaml#177
Merged
Conversation
The values.yaml trimming (keep only apiVersion, kind and metadata) should not apply to HelmRelease resources in the helm.toolkit.fluxcd.io group, since their spec (chart, values, etc.) is not sourced from schema defaults and must be preserved. Signed-off-by: Tamal Saha <tamal@appscode.com>
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Skip the fusion
values.yamltrimming (introduced in #174) forHelmReleaseresources in thehelm.toolkit.fluxcd.ioAPI group. For those, the full object is kept invalues.yaml.Why
#174 trims each resource entry to only
apiVersion,kindandmetadata, on the basis that the remaining fields are sourced from the resource's schema defaults. That assumption does not hold for aHelmRelease: itsspec(chart reference, chart version, values, etc.) is meaningful and cannot be reconstructed from schema defaults, so it must be preserved.Behavior
helm.toolkit.fluxcd.io/HelmRelease→ full object kept (as before fusion: keep only apiVersion, kind and metadata in values.yaml #174).apiVersion,kind,metadata(as in fusion: keep only apiVersion, kind and metadata in values.yaml #174).