Skip to content

ui-updater: log digest resolution failures instead of exiting #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tamalsaha merged 1 commit into from
Jun 2, 2026
Merged

ui-updater: log digest resolution failures instead of exiting #640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions cmd/ui-updater/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,11 +196,8 @@ func getDigestOrVersion(repo, bin, ver string) string {
ref := fmt.Sprintf("ghcr.io/appscode-charts/%s:%s", bin, ver)
digest, err := crane.Digest(ref, crane.WithAuthFromKeychain(authn.DefaultKeychain))
if err != nil {
// Don't silently downgrade from a pinned digest to a mutable tag —
// surface the failure so the operator can decide whether to retry
// or accept the un-pinned version.
fmt.Fprintf(os.Stderr, "ERROR: failed to resolve digest for %s: %v\n", ref, err)
os.Exit(1)
fmt.Fprintf(os.Stderr, "WARN: failed to resolve digest for %s: %v\n", ref, err)
return ver
}
return digest
}
Loading