ui-updater: log digest resolution failures instead of exiting#640
Merged
Conversation
When crane.Digest fails, warn to stderr and fall back to the version tag rather than aborting the entire run. Signed-off-by: Tamal Saha <tamal@appscode.com>
3 tasks
tamalsaha
added a commit
that referenced
this pull request
Jun 4, 2026
Restore the fail-loud behavior from #628 (reverted in #640), but skip digest resolution entirely when the chart name contains '{' or '}' (e.g. uik8sappscodecom-featureset-{.metadata.release.name}-editor) — those names are resolved at render time and have no fixed digest. Signed-off-by: Tamal Saha <tamal@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getDigestOrVersionincmd/ui-updater/main.gono longer exits whencrane.Digestfails — it now logs aWARNto stderr and falls back to the plain version tag so a transient registry/auth blip doesn't abort the whole refresh run.Test plan
go run ./cmd/ui-updater --use-digestwith valid auth → digests resolved as before.