Skip to content

ui-updater: log digest resolution failures instead of exiting#640

Merged
tamalsaha merged 1 commit into
masterfrom
fix/ui-updater-digest-log-only
Jun 2, 2026
Merged

ui-updater: log digest resolution failures instead of exiting#640
tamalsaha merged 1 commit into
masterfrom
fix/ui-updater-digest-log-only

Conversation

@tamalsaha

Copy link
Copy Markdown
Contributor

Summary

  • Reverts the hard-fail behavior introduced in ui-updater: fail loudly when digest resolution fails #628. getDigestOrVersion in cmd/ui-updater/main.go no longer exits when crane.Digest fails — it now logs a WARN to stderr and falls back to the plain version tag so a transient registry/auth blip doesn't abort the whole refresh run.

Test plan

  • Run go run ./cmd/ui-updater --use-digest with valid auth → digests resolved as before.
  • Point at an unreachable ref → tool logs the failure and continues with the tag version instead of exiting non-zero.

When crane.Digest fails, warn to stderr and fall back to the version
tag rather than aborting the entire run.

Signed-off-by: Tamal Saha <tamal@appscode.com>
@tamalsaha tamalsaha requested a review from ArnobKumarSaha June 2, 2026 13:26
@tamalsaha tamalsaha merged commit 729e625 into master Jun 2, 2026
6 checks passed
@tamalsaha tamalsaha deleted the fix/ui-updater-digest-log-only branch June 2, 2026 13:26
tamalsaha added a commit that referenced this pull request Jun 4, 2026
Restore the fail-loud behavior from #628 (reverted in #640), but skip
digest resolution entirely when the chart name contains '{' or '}'
(e.g. uik8sappscodecom-featureset-{.metadata.release.name}-editor) —
those names are resolved at render time and have no fixed digest.

Signed-off-by: Tamal Saha <tamal@appscode.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant