Skip to content

fix(client): add anti-echo guard for video syncing #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AbdulRashidReshamwala wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(client): add anti-echo guard for video syncing #166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions images/chromium-headful/client/src/components/video.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@
private focused = false
private fullscreen = false
private mutedOverlay = true
private isVideoSyncing = false

get admin() {
return this.$accessor.user.admin
Expand Down Expand Up @@ -431,6 +432,10 @@

@Watch('playing')
async onPlayingChanged(playing: boolean) {
// In Safari, native events can fire slightly before the `video.paused` property flips.
// This anti-echo guard prevents the watcher from fighting the video element's own state changes.
if (this.isVideoSyncing) return;

if (this._video && this._video.paused && playing) {
// if autoplay is disabled, play() will throw an error
// and we need to properly save the state otherwise we
Expand Down Expand Up @@ -511,11 +516,15 @@
})

this._video.addEventListener('playing', () => {
this.isVideoSyncing = true
this.$accessor.video.play()
this.$nextTick(() => { this.isVideoSyncing = false })
})

this._video.addEventListener('pause', () => {
this.isVideoSyncing = true
this.$accessor.video.pause()
this.$nextTick(() => { this.isVideoSyncing = false })
})

/* Initialize Guacamole Keyboard */
Expand Down
Loading