fix(client): add anti-echo guard for video syncing#166
Open
AbdulRashidReshamwala wants to merge 1 commit intokernel:mainfrom
Open
fix(client): add anti-echo guard for video syncing#166AbdulRashidReshamwala wants to merge 1 commit intokernel:mainfrom
AbdulRashidReshamwala wants to merge 1 commit intokernel:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an anti-echo guard to prevent play/pause event spams.
Note
Low Risk
Small, localized client-side state-sync change limited to play/pause handling; main risk is missing edge cases where the guard could mask legitimate state transitions.
Overview
Adds an anti-echo guard in
video.vueto stop play/pause state from repeatedly re-triggering itself when the native<video>events and the@Watch('playing')watcher race.This introduces an
isVideoSyncingflag: nativeplaying/pauselisteners temporarily set the flag while they dispatchthis.$accessor.video.play()/pause(), and the watcher now bails out when syncing to avoid event spam and state thrash (notably on Safari wherevideo.pausedcan lag).Written by Cursor Bugbot for commit bc77548. This will update automatically on new commits. Configure here.