Skip to content

fix(client): add anti-echo guard for video syncing#166

Open
AbdulRashidReshamwala wants to merge 1 commit intokernel:mainfrom
AbdulRashidReshamwala:fix-video-sync
Open

fix(client): add anti-echo guard for video syncing#166
AbdulRashidReshamwala wants to merge 1 commit intokernel:mainfrom
AbdulRashidReshamwala:fix-video-sync

Conversation

@AbdulRashidReshamwala
Copy link
Contributor

@AbdulRashidReshamwala AbdulRashidReshamwala commented Feb 25, 2026

Added an anti-echo guard to prevent play/pause event spams.


Note

Low Risk
Small, localized client-side state-sync change limited to play/pause handling; main risk is missing edge cases where the guard could mask legitimate state transitions.

Overview
Adds an anti-echo guard in video.vue to stop play/pause state from repeatedly re-triggering itself when the native <video> events and the @Watch('playing') watcher race.

This introduces an isVideoSyncing flag: native playing/pause listeners temporarily set the flag while they dispatch this.$accessor.video.play()/pause(), and the watcher now bails out when syncing to avoid event spam and state thrash (notably on Safari where video.paused can lag).

Written by Cursor Bugbot for commit bc77548. This will update automatically on new commits. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant