Fix: side navigation labels do not update on locale change - #563
Open
serhiihordiichuk wants to merge 2 commits into
Open
Fix: side navigation labels do not update on locale change#563serhiihordiichuk wants to merge 2 commits into
serhiihordiichuk wants to merge 2 commits into
Conversation
The navigation useMemo only recomputed on theme change, so the labels kept the locale that was active at first render. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TavbPaXhouNDFXLwR6hTHy
The previous fix used the context locale, which changes before the message catalog loads. Subscribe with useLingui and depend on i18n.locale so the memo recomputes after activation. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TavbPaXhouNDFXLwR6hTHy
serhiihordiichuk
force-pushed
the
fix-sidenav-locale
branch
from
August 27, 2026 10:54
4ed873b to
70ceb70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The side navigation labels (Boards, Templates, Members, Settings) stay in the locale that was active at first render. When a user switches the language, the rest of the interface updates, but the sidebar does not. A hard reload does not help either, because the saved locale activates after the first render.
Cause
SideNavigation.tsxbuilds the navigation items inside auseMemowith[isDarkMode]as its only dependency. Thetmacro values are computed once and cached, so a locale change never recomputes them.Fix
Read the active locale from the existing
useLocalisationhook and add it to the dependency array. The memo now recomputes when the language changes.This affects every language, not one specific locale. Related to #562 (where the issue was found while testing the Ukrainian translation).
🤖 Generated with Claude Code