Skip to content

fix(composer): normalize responsive effort icons - #210

Merged
kahme247 merged 10 commits into
kahme247:mainfrom
andrebrait:fix/effort-icon-sizing
Oct 5, 2026
Merged

kahme247 merged 10 commits into
kahme247:mainfrom
andrebrait:fix/effort-icon-sizing

Conversation

@andrebrait

Copy link
Copy Markdown
Collaborator

Summary

Follow up on the reasoning glyphs introduced in #194.

  • Keep larger icon-only reasoning controls on mobile and narrow toolbars, with smaller icons and level names on desktop.
  • Show the model icon on mobile, remove unused model/reasoning spacing, and preserve the toolbar's ability to shrink rather than unnecessarily wrapping.
  • Draw consistent, vertically centered circle/pie effort shapes using CSS and the existing Lucide Auto icon, avoiding unequal Unicode font fallback metrics and selected-state size changes.
  • Retain shape distinctions in Windows High Contrast, and show custom provider-defined effort names once with normal truncation.
  • Remove obsolete Unicode-glyph data and unused CSS selectors; add a regression test for custom effort labels.

Verification

  • npm run typecheck: passed.
  • npm run lint: passed with 11 existing warnings, no errors.
  • npm test: 1,133 passed, 5 platform-specific skips, 0 failures.
  • npm run build: passed (existing static Cache-Control warning).
  • Custom-label regression failed before the fix (ultraultra instead of ultra) and passed afterward.
  • The deployed local preview exercised every selectable level at 390px and 1280px; selected icons and menu shapes were centered and consistently sized.
  • Review fixes additionally exercised the actual ChatInput renderer in Chromium at 390/480/640/1280px with a Claude model and Fast/Slow controls, plus a long custom effort label. Standard toolbar controls stayed on one row; custom labels stayed inside their controls. Forced-colors emulation preserved the slash, fills and center dot. This supplementary check used an SSR fixture with the compiled browser stylesheet, not a running Next page; no Safari/Firefox or physical-phone testing is claimed.

No dependencies or API endpoints change. Please squash-merge the iterative sizing commits.

andrebrait added a commit to andrebrait/ompweb that referenced this pull request Oct 5, 2026
Squashed from origin/fix/effort-icon-sizing (0a367f6) onto upstream/main.
andrebrait added a commit to andrebrait/ompweb that referenced this pull request Oct 5, 2026
Squashed from origin/fix/effort-icon-sizing (0a367f6) onto upstream/main.
@andrebrait

Copy link
Copy Markdown
Collaborator Author

Follow-up: the effort menu now keeps one full-width level per row on mobile as well as desktop. Removed only the mobile flex-direction, flex-wrap and automatic button-width overrides; icon sizes and selection behavior remain unchanged. The full-width assertion failed before the change and passed after removing those exact overrides in Chromium at 320, 390, 640, 768 and 1280px. Selection remained functional. Local lint and production build passed (existing warnings unchanged). This update is not deployed yet.

@andrebrait

Copy link
Copy Markdown
Collaborator Author

Screenshot-based sizing follow-up: mobile/narrow toolbar effort icons are now 18px instead of 20px, and the Slow snail is enlarged from its actual 11px size to 14px. Menu icons remain 16px on mobile and 14px on desktop; full-width menu rows are preserved. Standard desktop toolbar sizes are unchanged. Browser preview checks passed at 320, 390, 640 and 1280px, including the High-level circle; vertical alignment stayed centered and the Slow button stayed 28x28px. Local lint and production build passed with the same existing warnings. These pending UI updates are not deployed yet.

andrebrait added a commit to andrebrait/ompweb that referenced this pull request Oct 5, 2026
Squashed from origin/fix/effort-icon-sizing (fa2d4f9) onto upstream/main.
@andrebrait
andrebrait marked this pull request as draft October 5, 2026 04:30
@andrebrait
andrebrait marked this pull request as ready for review October 5, 2026 04:30
@andrebrait

Copy link
Copy Markdown
Collaborator Author

The unchanged-code validation retry https://github.com/kahme247/ompweb/actions/runs/37263849206 passed on Linux and Windows. The earlier Linux failure was in Next Google-font loading. The current integration release 9559aa0 includes this PR at fa2d4f9. Verified the actual public UI after deployment: at 390px, toolbar effort 18px and Slow snail 14px, with menu icons still 16px; at 1280px, existing toolbar sizes and 14px menu icons are unchanged. Every menu option uses its full row width.

andrebrait added a commit to andrebrait/ompweb that referenced this pull request Oct 5, 2026
Squashed from origin/fix/effort-icon-sizing (fa2d4f9) onto upstream/main.
andrebrait added a commit to andrebrait/ompweb that referenced this pull request Oct 5, 2026
Squashed from origin/fix/effort-icon-sizing (fa2d4f9) onto upstream/main.
andrebrait added a commit to andrebrait/ompweb that referenced this pull request Oct 5, 2026
Squashed from origin/fix/effort-icon-sizing (fa2d4f9) onto upstream/main.
andrebrait added a commit to andrebrait/ompweb that referenced this pull request Oct 5, 2026
Squashed from origin/fix/effort-icon-sizing (fa2d4f9) onto upstream/main.
andrebrait added a commit to andrebrait/ompweb that referenced this pull request Oct 5, 2026
Squashed from origin/fix/effort-icon-sizing (fa2d4f9) onto upstream/main.
andrebrait added a commit to andrebrait/ompweb that referenced this pull request Oct 5, 2026
Squashed from origin/fix/effort-icon-sizing (fa2d4f9) onto upstream/main.
andrebrait added a commit to andrebrait/ompweb that referenced this pull request Oct 5, 2026
Squashed from origin/fix/effort-icon-sizing (fa2d4f9) onto upstream/main.
andrebrait added a commit to andrebrait/ompweb that referenced this pull request Oct 5, 2026
Squashed from origin/fix/effort-icon-sizing (b447af0) onto upstream/main.
andrebrait added a commit to andrebrait/ompweb that referenced this pull request Oct 5, 2026
Squashed from origin/fix/effort-icon-sizing (b447af0) onto upstream/main.
@kahme247
kahme247 merged commit 68c75ea into kahme247:main Oct 5, 2026
3 checks passed
kahme247 added a commit that referenced this pull request Oct 5, 2026
@andrebrait
andrebrait deleted the fix/effort-icon-sizing branch October 6, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants