fix(ui): restore tool selection feedback in onboarding and render selected tool names in review#1633
fix(ui): restore tool selection feedback in onboarding and render selected tool names in review#1633whtssub wants to merge 4 commits intokagent-dev:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a blocker bug where users cannot select tools in the UI quick agent builder wizard's tool selection step. The issue was caused by server name format mismatches during tool selection comparison. Additionally, the PR improves the tool feedback in the review step by displaying individual tool names instead of just server names, and fixes duplicate key warnings in the UI.
Changes:
- Normalize server-name matching in ToolSelectionStep to handle both "namespace/name" and plain name formats using a new
serverNamesMatchutility function - Improve ReviewStep rendering to display individual tool names per tool and generate unique keys per tool to eliminate React duplicate key warnings
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ui/src/components/onboarding/steps/ToolSelectionStep.tsx | Imports and uses serverNamesMatch function to properly match tools when server names may be in different formats (namespace/name vs plain name) |
| ui/src/components/onboarding/steps/ReviewStep.tsx | Refactors tool rendering to show individual tool names instead of just server names, uses flatMap for better data structure handling, and generates unique keys combining server name, tool name, and tool index to fix duplicate key issues |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ected tool names in review Signed-off-by: SubhasmitaSw <subhasmitaswain232@gmail.com>
|
This pull request has been marked as stale because of no activity in the last 15 days. It will be closed in the next 5 days unless it is tagged "no stalebot" or other activity occurs. |
| const serverName = tool.mcpServer?.name || "unknown-server"; | ||
| const toolNames = tool.mcpServer?.toolNames || []; | ||
|
|
||
| if (toolNames.length === 0) { |
There was a problem hiding this comment.
shouldn't we just ignore this and not even show anything? if there's no tools, the MCP server is useless
peterj
left a comment
peterj
left a comment
There was a problem hiding this comment.
one comment that I think should be resolved before we merge
Normalize server-name matching for Step 3 checkboxes and use unique per-tool keys in Step 4 to fix duplicate key issues.
refs #1614
I have rendered/tested the updated docker image locally and found consistent desired results. Refer the below images.