Skip to content

refactor: tidy this sprint's checker, emitter and overflow code #1403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kacy merged 4 commits into from
Nov 15, 2026
Merged

refactor: tidy this sprint's checker, emitter and overflow code #1403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
919a6c4
refactor: one helper for a declaration's parameter names
kacy Nov 15, 2026
f37c86b
refactor: name the plain-arithmetic flag for what it covers
kacy Nov 15, 2026
4e28d27
refactor: drop the parameters the overflow check no longer uses
kacy Nov 15, 2026
56bb415
chore: refresh the bootstrap seed
kacy Nov 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions cranelift/codegen/src/ir_consumer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1812,10 +1812,7 @@ fn checked_operand_range(op: &str, c: i64, const_on_left: bool) -> Option<(i128,
/// test it, and a constant multiply in that form takes the slow one-operand
/// `imul`; the compare fuses with its branch and leaves the arithmetic alone.
fn emit_checked_int_arith(
codegen: &mut CodeGen,
builder: &mut FunctionBuilder<'_>,
func_ref_cache: &mut HashMap<FuncId, FuncRef>,
runtime_funcs: &HashMap<String, FuncId>,
op: &str,
a: Value,
b: Value,
Expand Down Expand Up @@ -1876,7 +1873,6 @@ fn emit_checked_int_arith(
// the runtime turns the trap into the integer-overflow error
// (overflow_trap.rs).
builder.ins().trapnz(overflowed, cranelift::codegen::ir::TrapCode::unwrap_user(OVERFLOW_TRAP_CODE));
let _ = (codegen, func_ref_cache, runtime_funcs);
Ok(match computed {
Some(value) => value,
None => plain(builder),
Expand Down Expand Up @@ -3280,10 +3276,7 @@ fn compile_ir_function(
} else {
let v = match parts[0] {
"addc" | "subc" | "mulc" | "uaddc" | "usubc" | "umulc" => emit_checked_int_arith(
codegen,
&mut builder,
&mut func_ref_cache,
runtime_funcs,
checked,
a,
b,
Expand Down
Loading
Loading