Repository navigation
refactor: tidy this sprint's checker, emitter and overflow code - #1403
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A cleanup pass over this sprint's changes, with no change in behavior:
check_argument_labelsandcheck_holding_calleach collected a declaration's parameter names; both now usedeclared_param_names.ir_plain_int_arith.emit_checked_int_arithstill took the codegen, func-ref cache and runtime table it needed when the overflow path was a runtime call. The path is a trap now, so those parameters are gone.Runtime and codegen tests, regressions on both ABIs, std, examples, the invalid, diagnostic, cli and lsp goldens, the abort goldens and the crash guard all pass. The bootstrap seed is refreshed.