Repository navigation
fix: serve gRPC over TLS when tls-port is set - #457
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gRPC only served plaintext. A server configured with
tls-portencrypted RESP but still served the same data in the clear on the gRPC port, 6380 by default. The Docker image binds it to 0.0.0.0.tls-portis set, gRPC uses the same certificate, key and client certificate settings, plus ALPNh2. The rustls config is split out ofload_tls_acceptorso both acceptors share itgrpc::tls::incomingaccepts connections and runs our existing handshake (with its 10 s timeout) in a task per connection. It hands the streams toserve_with_incoming. The wrapper reportsTcpConnectInfo, so protected mode still sees the peer addressTests:
h2gets PONG. The test connects through tonic's custom connector, usinghyper-utilandtower, which tonic already depends on