Repository navigation
fix: close connection, auth and transaction gaps - #458
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The open medium items from the audit for connections, auth and gRPC limits. One commit per fix:
dispatch::process, which skips the transaction handler. WithAUTH,MULTI,SET,EXECin one write, MULTI was refused as nested, SET ran at once and EXEC failed. Inside an open MULTI, commands stopped queueing. They now go throughhandle_frame_with_txmax_command_memory(128 MiB), since a transaction counts as one command. Past it, the command is refused, EXEC returns EXECABORT, and WATCH returns an errorrequirepassmaxclients: the gRPC listener from fix: serve gRPC over TLS when tls-port is set #457 now serves plaintext too, and takes a place from the semaphore RESP connections use. It sets TCP_NODELAY and a 60 s keepalive, which tonic'sserve()did beforeEach fix has a test: the AUTH batch (fails on main), ACL atomicity, a 132 MiB transaction, config permissions, and gRPC refused while a RESP client holds the only place.