Skip to content

test(gkb): the #532 fix still finds an unowned document beside a contribution #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jwvanderstam wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(gkb): the #532 fix still finds an unowned document beside a contribution #547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/integration/test_gkb_contribution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,5 +259,9 @@ def test_a_contribution_is_not_mistaken_for_a_document_without_a_workspace(datab
filename = f"gkb-nows-{uuid.uuid4().hex[:8]}.txt"
doc = _document(database, workspaces["a"], filename)
global_id = database.contributions.contribute(workspaces["a"], [doc], admin)[0]["global_document_id"]
assert database.documents.exists(filename, None)[0] is False
# Beside it, the documents both queries must still find: one with no workspace, and the source.
unowned = database.documents.insert(filename, "unowned content", workspace_id=None, scope=ALL_WORKSPACES)
stale_ids = {d["id"] for d in database.documents.stale(0, scope=ALL_WORKSPACES)}
assert (database.documents.exists(filename, None)[0], global_id in stale_ids) == (False, False)
assert (database.documents.exists(filename, None)[1]["id"], {doc, unowned, global_id} & stale_ids) == (
unowned, {doc, unowned})
Loading