Repository navigation
test(gkb): the #532 fix still finds an unowned document beside a contribution - #547
Open
jwvanderstam wants to merge 1 commit into
Open
jwvanderstam wants to merge 1 commit into
jwvanderstam wants to merge 1 commit into
Conversation
…ribution The test proved a contribution is no longer matched as a document without a workspace. It did not prove the queries still match the documents they should: a fix that made `exists(filename, None)` and `stale()` return nothing would have passed it. It now inserts an unowned document of the same filename, and asserts `exists` returns that one and `stale` returns it and the source, but not the contribution. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KkWPq9YWxtZ6hbDvMft8fh
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #532, rescued from a worktree where it was left uncommitted.
test_a_contribution_is_not_mistaken_for_a_document_without_a_workspaceproved the contribution is no longer matched. It did not prove thatexists(filename, None)andstale()still match what they should, so a fix that made both return nothing would have passed. The test now inserts an unowned document with the same filename and asserts:existsreturns that document;stalereturns it and the source document, but not the contribution.This changes the test only. Against Postgres:
tests/integration/test_gkb_contribution.py, 13 passed.🤖 Generated with Claude Code
https://claude.ai/code/session_01KkWPq9YWxtZ6hbDvMft8fh