Repository navigation
fix: keep assistants running when earlier background commands finish - #43
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Home stopped accepting requests after an older background command completed during its current turn. The observer treated that earlier turn ID as a conversation mismatch, marked the request uncertain, and blocked automatic recovery despite the current turn later completing normally.
Ignore only
CommandExecutioncompletions from the same conversation whose valid UUIDv7 turn timestamp is strictly earlier than the current turn. These events never contribute to the current result. Other conversations, missing/unordered IDs, same-millisecond or newer IDs, non-command events and overlapping task starts continue to fail closed. No request replay or relaxation of completion evidence.Fixes #42.
Validation: 59 assistant request/recovery tests pass, including eight new regression cases and a durable dispatch/completion test proving one submission and the current answer. Replayed the actual production incident transcript: the exact request now projects as completed with its matching native turn. Typecheck, lint, format and lockfile checks pass. Existing shared assistant WIP remains separate. Deployment will update only the observer module while retaining the already-deployed assistant behavior; no frontend rebuild is needed.