Repository navigation
fix: restore assistant handoff after late background results - #44
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
|
Implemented and deployed through merged fork PRs #43 and #44. Two related causes were fixed:
Only scoped background command events are ignored/recognized. Other conversations, newer or ambiguous turn IDs, user-message events and actual new task starts still fail closed. No task was replayed, no background command stopped, and no uncertain result relabeled as successful in the durable ledger. Validation: 66 request/recovery tests passed on the clean feature branch; 70 passed with the existing deployed assistant changes included. Typecheck, lint, formatting, lockfile, frontend syntax, public assets and all pre-push static gates passed. The actual incident transcript projects as completed for the exact request turn, and its full conversation is now ready despite the trailing background result. Production deployment at 2026-11-03 15:26:25 Asia/Dubai: installed only the verified observer/request-manager JS modules and source maps, preserving the already-deployed uncommitted parser/recovery behavior and all unrelated frontend artifacts. Restarted GitHub CI for #44 was still in progress when this deployment verification completed; local passing checks are not a claim that remote CI has finished. |
After #43 fixed observation of older background commands, live deployment verification found Home could still fail handoff: the background command from its completed turn finished afterward, so the readiness detector treated that late result as an unfinished native turn.
Recognize a completed conversation as idle when subsequent native events are only command completions from that same turn or a demonstrably older UUIDv7 turn in the bound conversation. Later task starts, user messages, foreign conversations, newer turns and missing identities still prevent handoff. Keep strict parsing and completion evidence; do not stop or replay background work.
Follow-up for #42 and #43. Local request/recovery suite: 66 tests pass, including seven new handoff cases. The deployment candidate correctly recognizes Home's full real transcript as ready and its exact request as completed, while preserving already-deployed unrelated assistant parser/recovery changes. Existing shared WIP remains separate.