Handle truncated TLV values as recoverable diagnostics#12
Closed
SoorajDe wants to merge 2 commits into
Closed
Conversation
Owner
|
This PR is related to issues #4 |
Owner
|
@SoorajDe I’d prefer to keep the review focused specifically on the TLV truncation recovery path and its associated regression coverage before considering the other changes. |
Owner
|
@SoorajDe why did you close this PR .? |
Contributor
Author
|
Hi jmestwa-coder,
I closed the previous PR because I have opened a new one that addresses the
feedback provided.
…On Tue, May 26, 2026 at 7:33 PM jmestwa-coder ***@***.***> wrote:
*jmestwa-coder* left a comment (jmestwa-coder/sigflow#12)
<#12 (comment)>
@SoorajDe <https://github.com/SoorajDe> why did you close this PR .?
—
Reply to this email directly, view it on GitHub
<#12?email_source=notifications&email_token=BKMSO5NZIEX5ECKKUM5BVHD44WP33A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINJUGQ4DAMBSGAZ2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4544800203>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BKMSO5OAGATISWUZIC5WXTT44WP33AVCNFSM6AAAAACZM6PWNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DKNBUHAYDAMRQGM>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Owner
|
@SoorajDe you can make the changes locally and push them with a new commit, or amend the previous commit and force-push to update the PR. |
Contributor
Author
|
i have already sent another PR
…On Tue, May 26, 2026 at 7:43 PM jmestwa-coder ***@***.***> wrote:
*jmestwa-coder* left a comment (jmestwa-coder/sigflow#12)
<#12 (comment)>
@SoorajDe <https://github.com/SoorajDe> you can make the changes locally
and push them with a new commit, or amend the previous commit and
force-push to update the PR.
—
Reply to this email directly, view it on GitHub
<#12?email_source=notifications&email_token=BKMSO5LBPYLXAD7LL5APSUL44WRA5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINJUGQ4TAMBWGY22M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4544900665>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BKMSO5LDP42AJGMJRYQQWQT44WRA5AVCNFSM6AAAAACZM6PWNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DKNBUHEYDANRWGU>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made:
sigflow/parsers/tlv.pycontext.warn("tlv-truncated", ...)and stops parsing gracefully instead of raising
ParseError("truncated input")Tests:
test_tlv_truncated_value_is_recoverabletlv-truncateddiagnostic is emittedVerification:
python -m pytest -q