Fix: recoverable diagnostics for truncated TLV value#14
Merged
Conversation
Owner
Owner
|
LGTM, Merging. |
Owner
|
@SoorajDe, Thank you for your contribution. The submitted fix has been reviewed and merged successfully. You have successfully completed this evaluation task and have been shortlisted for the next round of the selection process. Please send the following details to shortlist@digiscrypt.com for verification purposes: Pull Request link |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix:
sigflow/parsers/tlv.pynow treats truncated TLV values (header parsed, but declared value length exceeds remaining bytes) as recoverable diagnostics instead of raising a hardParseError.Behavior:
context.warn("tlv-truncated", ...)breakTests:
added regression coverage in
tests/test_parsers.pyverifies truncated TLV input:
ParseErrortlv-truncateddiagnosticValidation:
pytest -q