Change some marcos and API calls to be suitable for windows#119
Open
unbadfish wants to merge 3 commits into
Open
Change some marcos and API calls to be suitable for windows#119unbadfish wants to merge 3 commits into
unbadfish wants to merge 3 commits into
Conversation
Author
|
When upgrading synctex in https://github.com/sumatrapdfreader/sumatrapdf , I came up with some compile error. This PR is mainly from sumatrapdfreader/sumatrapdf@374896d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My editor deleted some trailing spaces, which makes a lot of differences between old file and new file. The main edits are simple:
synctex_parser_utils.c: L 168-169As synctex is based on 8 bits characters, including UTF8, not 16 bits nor 32 bits, change default API calls (auto expand to
W) toAs.synctex/synctex_parser.h
Lines 91 to 93 in 9176177
synctex_parser_utils.h: L 90GCC's
__attribute__extension is not useable in windows. re-define it to dummy.https://stackoverflow.com/questions/28411283/dealing-with-attribute-in-msvc