Skip to content

Second attempt to fix forward/backward synchronization#5562

Merged
kjk merged 7 commits into
sumatrapdfreader:masterfrom
unbadfish:sync2
Apr 20, 2026
Merged

Second attempt to fix forward/backward synchronization#5562
kjk merged 7 commits into
sumatrapdfreader:masterfrom
unbadfish:sync2

Conversation

@unbadfish

Copy link
Copy Markdown
Contributor

This probably fix #5410

Main Fix:
414df7a

Test files:

SYNCXYZ.zip

Test record:

2026-04-20.15-46-55-cut.mp4

Reverts previous commit to fix bug in a clean environment.

This reverts commit 97c242d.
Update synctex to vanilla synctex 2026-1 (v1.31) for further bug fix.

This commit partly reverts commit 8c85283 .

Some compare:
jlaurens/synctex@ded1157...82f46b6

jlaurens/synctex@7a58bbc...82f46b6
1. A/W windows API
2. revert attribute-related marco to 2023.4 (upstream c3641da)
Supports:
- ASCII or ansi in path,
- plain or gz sync file,
- compiled by "pdflatex, xelatex" or "lualatex" (utf-8 or ansi in file content).
@GitHubRulesOK

GitHubRulesOK commented Apr 20, 2026

Copy link
Copy Markdown
Collaborator

@kjk just a basic comment that you can test the effect very easily by set echo as a substitute for the editor

InverseSearchCmdLine = CMD /K chcp 936 && ECHO file=%f line=%l hint=%c && pause
image

This will ensure CMD sees the correct CHCP coding for the users environment (Chinese in this case=936 , can be 65001 for ISO, etc etc) also will show if %f in CMD mandates "%f" (for windows filenames with spaces) that would break the unguarded cmd call and also show if %c was ever set but SumatraPDF is not expected to support that variable.

@unbadfish

Copy link
Copy Markdown
Contributor Author

The synctex in this repo is not vanilla. Patches in commit 374896d have been sent to upstream.

See jlaurens/synctex#119

@kjk kjk merged commit 9e2655a into sumatrapdfreader:master Apr 20, 2026
1 check failed
@kjk

kjk commented Apr 20, 2026

Copy link
Copy Markdown
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Forward and Backward synchronizations failed when path contains non-ASCII characters

3 participants