Skip to content

Deprecate getOldGitExe() method #3936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarkEWaite merged 4 commits into from
Mar 21, 2026
Merged

Deprecate getOldGitExe() method #3936

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cba0165
Remove dead getOldGitExe() code and empty onLoaded() block
meetgoti07 Mar 15, 2026
2324d89
remove onLoaded method
meetgoti07 Mar 16, 2026
b0b8491
Merge branch 'master' into remove_dead_codeblock
MarkEWaite Mar 21, 2026
cd2c37e
Deprecate method instead of deleting it
MarkEWaite Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 5 additions & 18 deletions src/main/java/hudson/plugins/git/GitSCM.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1811,10 +1811,12 @@ public void setAllowSecondFetch(boolean allowSecondFetch) {
public void setAddGitTagAction(boolean addGitTagAction) { this.addGitTagAction = addGitTagAction; }

/**
* Old configuration of git executable - exposed so that we can
* migrate this setting to GitTool without deprecation warnings.
* @return git executable
* Old configuration of git executable, unused since 2023.
* Returns null in all cases.
* @deprecated use GitTool
* @return null
*/
@Deprecated(since = "5.11.0")
public String getOldGitExe() {
return null;
}
Expand Down Expand Up @@ -2166,21 +2168,6 @@ public boolean getDoGenerateSubmoduleConfigurations() {
return doGenerateSubmoduleConfigurations;
}

@Initializer(after=PLUGINS_STARTED)
public static void onLoaded() {
Jenkins jenkins = Jenkins.get();
DescriptorImpl desc = jenkins.getDescriptorByType(DescriptorImpl.class);

if (desc.getOldGitExe() != null) {
String exe = desc.getOldGitExe();
String defaultGit = GitTool.getDefaultInstallation().getGitExe();
if (exe.equals(defaultGit)) {
return;
}
System.err.println("[WARNING] you're using deprecated gitexe attribute to configure git plugin. Use Git installations");
}
}

@Initializer(before=JOB_LOADED)
public static void configureXtream() {
Run.XSTREAM.registerConverter(new ObjectIdConverter());
Expand Down
Loading