Deprecate getOldGitExe() method#3936
Merged
MarkEWaite merged 4 commits intojenkinsci:masterfrom Mar 21, 2026
Merged
Conversation
Contributor
Author
|
@MarkEWaite |
MarkEWaite
added
the
chore
Contributor
I think that it is safe to remove it totally. |
Contributor
Author
|
@MarkEWaite I have totally removed the onLoaded method |
Preserve API compatibility for consumers. Low risk to delete it, but it is simpler for maintainers if we retain the method rather than answer later questions about its removal.
MarkEWaite
approved these changes
Mar 21, 2026
MarkEWaite
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove dead code:
DescriptorImpl.getOldGitExe()always returnsnull, so theif (desc.getOldGitExe() != null)block inonLoaded()never runs. This removes that block, the unusedgetOldGitExe()method (and its Javadoc), and the now-unuseddescvariable soonLoaded()is an empty initializer.Testing done
Refactor/cleanup only: no behavior change. The removed code was unreachable because
getOldGitExe()always returnsnull. Ran the existing test suite (e.g.mvn test) to confirm nothing regresses. No new tests added for removal of dead code.Submitter checklist