Skip to content

deps: declare dbus-fast (linux) as a core dependency so Wi-Fi connect works on a standard install (recut of tsk-vu2n4k) - #4009

Merged
jaylfc merged 2 commits into
devfrom
exec/tsk-wwqlgh
Oct 27, 2026
Merged

jaylfc merged 2 commits into
devfrom
exec/tsk-wwqlgh

Conversation

@jaylfc

@jaylfc jaylfc commented Oct 27, 2026

Copy link
Copy Markdown
Owner

CARD TITLE (intent, not commit subject): deps: declare dbus-fast (linux) as a core dependency so Wi-Fi connect works on a standard install (recut of tsk-vu2n4k)

Autonomous build of board card tsk-wwqlgh.

REVIEW WARNING (automated): this card's text asks for tests, but the diff changes no test file. Either the acceptance criteria are unmet or the card needs correcting. Do not merge without resolving this.

[tsk-wwqlgh] deps: declare dbus-fast (linux) as a core dependency so Wi-Fi connect works on a standard install

tsk-wwqlgh: declare dbus-fast as core dep on linux for wifi connect

Docs-Reviewed: no docs change needed

Files:
changelog.d/tsk-wwqlgh-dbus-fast-core-dep.md | 2 ++
pyproject.toml | 2 ++
uv.lock | 2 ++
3 files changed, 6 insertions(+)

In-house review (pre-PR)

in-house-review: BLOCK -> 1 fix round (fix round committed 44c593a) -> PASS (kilo/nvidia/nemotron-3-ultra-550b-a55b:free)

reviewer output

VERDICT: PASS

  • NIT: changelog fragment line could match card's exact phrasing "declare dbus-fast (linux) as a core dependency so Wi-Fi connect works on a standard install" but current wording is functionally equivalent

In-house-Review: PASS model=kilo/nvidia/nemotron-3-ultra-550b-a55b:free head=44c593afe needs-lead=0

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

@coderabbitai

coderabbitai Bot commented Oct 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 39 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between ef166ba and 44c593a.

Files ignored due to path filters: 1
  • uv.lock is excluded by !**/*.lock, !**/uv.lock
Files selected for processing: 2
  • changelog.d/tsk-wwqlgh-dbus-fast-core-dep.md
  • pyproject.toml
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gitar-bot

gitar-bot Bot commented Oct 27, 2026

Copy link
Copy Markdown

Important

You are using the Gitar free plan. Upgrade to unlock code review, CI analysis, auto-apply, custom automations, and more.

Gitar

@jaylfc jaylfc added the needs-jay Automerge refused (sensitive path / unreadable compare): Jay merges. Not counted in the lane PR cap. label Oct 27, 2026
@jaylfc

jaylfc commented Oct 27, 2026

Copy link
Copy Markdown
Owner Author

Lead review (taOS-dev): diff matches the card, but the card was incomplete: scripts/install-constraints.txt must be regenerated with the new dep (shards: constraints 99 vs install set 100). Fix-forward carded. Gate integrity fails by design (pyproject.toml is a protected gate file); I add gate-integrity-allow once the chain is green. Dependency path: Jay merges.

jaylfc added a commit that referenced this pull request Oct 27, 2026
fix-forward #4009 (tsk-wwqlgh): regenerate scripts/install-constraints.txt for the new dbus-fast core dependency
@jaylfc
jaylfc merged commit 44c593a into dev Oct 27, 2026
35 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-jay Automerge refused (sensitive path / unreadable compare): Jay merges. Not counted in the lane PR cap.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant