Skip to content

fix-forward #4009 (tsk-wwqlgh): regenerate scripts/install-constraints.txt for the new dbus-fast core dependency - #4014

Merged
jaylfc merged 4 commits into
devfrom
exec/tsk-yevqyj
Oct 27, 2026
Merged

jaylfc merged 4 commits into
devfrom
exec/tsk-yevqyj

Conversation

@jaylfc

@jaylfc jaylfc commented Oct 27, 2026 •

Copy link
Copy Markdown
Owner

CARD TITLE (intent, not commit subject): fix-forward #4009 (tsk-wwqlgh): regenerate scripts/install-constraints.txt for the new dbus-fast core dependency

Autonomous build of board card tsk-yevqyj.

REVIEW WARNING (automated): this card's text asks for tests, but the diff changes no test file. Either the acceptance criteria are unmet or the card needs correcting. Do not merge without resolving this.

REVISION: built on exec/tsk-wwqlgh (cut at 44c593afe595a92114db4a26096306efcfc9522e), not on dev. That branch's
commits are ancestors of this one. Verified by git merge-base --is-ancestor
before the PR was opened.

Fix: regenerate install-constraints.txt for dbus-fast core dependency

The uv export command adds dbus-fast==5.0.22 to the constraints file,
matching the updated install set after dbus-fast was added to core deps.

Docs-Reviewed: scripts/install-constraints.txt is a generated constraints file, not an installer; no README.md update needed.

Files:
changelog.d/tsk-wwqlgh-dbus-fast-core-dep.md | 2 ++
pyproject.toml | 2 ++
scripts/install-constraints.txt | 1 +
uv.lock | 2 ++
4 files changed, 7 insertions(+)

In-house review (pre-PR)

in-house-review: PASS (kilo/nvidia/nemotron-3-ultra-550b-a55b:free)

reviewer output

VERDICT: PASS

  • NIT: The diff correctly adds exactly one line for dbus-fast==5.0.22 as required by the card. No other changes shown.

In-house-Review: PASS model=kilo/nvidia/nemotron-3-ultra-550b-a55b:free head=feb902338 needs-lead=0

Summary by CodeRabbit

  • Bug Fixes
    • Fixed Wi-Fi PSK connections over the system bus on Linux, improving connection reliability.

The uv export command adds dbus-fast==5.0.22 to the constraints file,
matching the updated install set after dbus-fast was added to core deps.

Docs-Reviewed: scripts/install-constraints.txt is a generated constraints file, not an installer; no README.md update needed.
@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Files ignored due to path filters: 1
  • uv.lock is excluded by !**/*.lock, !**/uv.lock
Run configuration
Commits

Reviewing files that changed from the base of the PR and between feb9023 and 8ab9b54.

Files ignored due to path filters: 1
  • uv.lock is excluded by !**/*.lock, !**/uv.lock

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 1d8dcbf and feb9023.

Files ignored due to path filters: 1
  • uv.lock is excluded by !**/*.lock, !**/uv.lock
Files selected for processing: 3
  • changelog.d/tsk-wwqlgh-dbus-fast-core-dep.md
  • pyproject.toml
  • scripts/install-constraints.txt

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

Walkthrough

The project adds dbus-fast as a Linux-only core dependency, pins it to version 5.0.22 in the installation constraints, and records the change in the changelog.

Changes: Linux dbus-fast dependency

Layer / File(s) Summary
Declare and constrain dbus-fast
pyproject.toml, scripts/install-constraints.txt, changelog.d/tsk-wwqlgh-dbus-fast-core-dep.md
The project declares dbus-fast as a Linux-only core dependency, pins version 5.0.22 in the installation constraints, and adds a changelog entry describing its use for Wi-Fi PSK connection over the system bus.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Possibly related PRs

  • jaylfc/taOS#3995: Fixes _nm_add_and_activate, the Wi-Fi PSK path that uses dbus-fast over the system bus.
  • jaylfc/taOS#3991: Adds the Wi-Fi PSK connection route that uses in-process dbus-fast.
  • jaylfc/taOS#4007: Updates Wi-Fi connection implementation and NetworkManager D-Bus calls that use dbus-fast.
Merge Risk: Minimal · previous review feb90

The README requirement is satisfied by the commit’s documentation waiver. No established issue blocks merge, though the task-card test criterion should be confirmed by its owner.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title accurately identifies the regeneration of scripts/install-constraints.txt and links it to the new dbus-fast core dependency, which matches the main changeset.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)

Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gitar-bot

gitar-bot Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Gitar is working

Verification

Rules No rules evaluated

Functional validation Not enabled

Set up

Auto-approval Not enabled

Set up

Gitar

@jaylfc jaylfc added the needs-jay Automerge refused (sensitive path / unreadable compare): Jay merges. Not counted in the lane PR cap. label Oct 27, 2026
@jaylfc

jaylfc commented Oct 27, 2026

Copy link
Copy Markdown
Owner Author

Lead review PASS on feb9023 (card tsk-yevqyj). install-constraints gains dbus-fast==5.0.22, matching the uv.lock entry; the pyproject.toml touch is the one dependency line (linux marker), no gate logic, so gate-integrity-allow is set to acknowledge it. Merging this supersedes #4009. needs-jay stays: dependency path, Jay merges.

@jaylfc

jaylfc commented Oct 27, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@jaylfc jaylfc added the gate-integrity-allow Reviewed exception: allows a PR past the gate-integrity check label Oct 27, 2026
@jaylfc

jaylfc commented Oct 27, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@jaylfc
jaylfc merged commit d19816e into dev Oct 27, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gate-integrity-allow Reviewed exception: allows a PR past the gate-integrity check needs-jay Automerge refused (sensitive path / unreadable compare): Jay merges. Not counted in the lane PR cap.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant