Repository navigation
fix(pl-127): Events enrollment saves without a taught Save; panel never saves an unread shape - #108
Merged
Merged
Conversation
… form's own Save; the panel never saves an unread shape through the old step list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use case #6 (Odoo Events enrollment).
What broke
The owner taught Events and stopped on the new attendee's form without pressing Odoo's Save, an unlabeled cloud icon. The shape refused it ("didn't see the change saved"). The task the owner then saved, "attenddee task", was built by the panel's old step-list path. That path only runs when the panel holds no shape for the recording. The task:
Fix
packages/compiler/shape.py: a change with no Save click and no leave is taught as a leave, not refused.packages/compiler/compiler.py: the newsave_new_formoption presses the form's own Save after the last fill. It reuses PL-123's explicit-save step (Save / Save manually) and checks that the saved page landed and shows the email.services/api/compile.py: setssave_new_formfor a create that was never saved or left.apps/web/src/panel/PanelTeach.tsx: a stopped recording is always asked for its shape before saving.The Events task now compiles to:
It contains no event-card click.
Tests
tests/api/test_pl127_events_no_save.py: the owner's recording, rebuilt from the saved task. It failed before the fix.apps/web/tests/pl127ShapeUnread.test.tsx: an unread shape. It failed before the fix.test_pl125_shape.py: the never-saved update is now a leave.Not verified