Repository navigation
fix(pl-128): Events save the page already made; prices decided by the site - #109
Merged
Merged
Conversation
… update is decided by the site, not skipped from the ledger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the two failures from the owner's 2026-10-28 Sales + Events demo (runs f5541185 and 3ee94ed1).
Events: Ava Patel added, but the row failed
submitting -> failed. Ava is correctly on the list (Odoo attendee 5).submitting -> reconciling -> verifiedthroughverify_commit, so itscommitted_keysrow is written. Otherwise the row fails exactly as before.Sales: Oak Standing Desk showed 100 but was skipped
committed_keys. It sets the value and reads it back. A key committed again for an update is expected, not aduplicate_detectedincident. Creates keep both rules unchanged.LEDGER_SPEC.md(the pre-batch skip row and I8) now say so.Not in this PR
Checks
tests/runner/test_pl128_demo_fixes.py. The two demo cases failed on main and pass here. The three guard cases (no proof before, check fails, a create still skipped) pass on both.tests/runner: 330 passed.ruff check .is clean.