Commit package-lock.json and build oauth-exchange with npm ci - #322
Merged
Conversation
- commit the lockfile and copy it explicitly in the Dockerfile, so a missing lock fails the build instead of resolving a different tree - declare the Node version and pin the manifest (.nvmrc = 24, engines, private, exact versions) - ignore node_modules, which was not covered by any .gitignore Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oauth-exchangehad no lockfile, and the image was built withnpm install --omit=devandCOPY package*.json, so each build resolved its own dependency tree.Changes
.nvmrc= 24,engines,private, exact versions)node_modules, not covered by any.gitignoreuntil nowNotes
node:24-alpine3.23in place of thedhi.iohardened images, which need a login): the service starts normally.oauth-exchangeonly;dashgit-webfollows in a separate PR.🤖 Generated with Claude Code