Commit test lockfiles, run CI with npm ci and check the app importmap - #323
Merged
Conversation
- commit the lockfiles of dashgit-web/test and e2e (they were ignored), so the dependency graph sees the transitive tree and security updates work - run both test jobs with npm ci, pinning the Node version from .nvmrc and caching by lockfile; declare the manifests (private, engines, dev deps) - guard the app manifest, which stays without lockfile on purpose: document why in package.json and add a test that fails if the versions declared for dependabot and the ones pinned in the index.html importmap diverge Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third batch of the Node.js lockfile policy, covering the test/CI directories of
dashgit-web. Follows #322 (oauth-exchange).dashgit-web/testanddashgit-web/e2e: they were explicitly ignored, which left both directories invisible to the dependency graph — a vulnerability in a transitive dependency produced neither alert nor PR. Removing them from.gitignoreand committing the locks is what enables Dependabot security updates there.npm ciintest-utandtest-e2e, with the Node version taken from.nvmrcand the npm cache keyed by the lockfile. The manifests are declared as they should be:private,engines, and the test dependencies moved todevDependencies.dashgit-web/appkeeps its exception (declarative manifest, no lockfile, never installed). Its purpose is now documented in the manifest itself, andTestImportmap.jsfails if the versions Dependabot bumps inapp/package.jsonstop matching the ones pinned in theindex.htmlimportmap — the manual step that until now could be forgotten silently.Notes
versioning-strategy: increaseis added to both npm entries ofdependabot.yml: the defaultautoheuristic classifies a manifest as application or library by guessing, and it is not reliable here.dashgit-web/test(sinon) predates the lockfile and will need a rebase after this merges.🤖 Generated with Claude Code