fix: Handle paginated URLs and add HTTP timeouts#178
Open
jqnatividad wants to merge 1 commit intojaemk:masterfrom
Open
fix: Handle paginated URLs and add HTTP timeouts#178jqnatividad wants to merge 1 commit intojaemk:masterfrom
jqnatividad wants to merge 1 commit intojaemk:masterfrom
Conversation
Release fetching now preserves pagination URLs that already contain query parameters (e.g. from Link headers) instead of unconditionally appending `?per_page=100`. The reqwest HTTP client is configured with a 30s connect timeout and a 300s overall timeout (and imports Duration) to avoid long-hanging requests. These changes fix malformed pagination requests and make network calls more resilient.
GideonBear
requested changes
Apr 9, 2026
Collaborator
GideonBear
left a comment
GideonBear
left a comment
There was a problem hiding this comment.
If you split this up I can merge the pagination fix
| let client = client_builder.http2_adaptive_window(true).build()?; | ||
| let client = client_builder | ||
| .http2_adaptive_window(true) | ||
| .connect_timeout(Duration::from_secs(30)) |
Collaborator
Contributor
Author
There was a problem hiding this comment.
Copy. I'll just submit a pagination fix PR then...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release fetching now preserves pagination URLs that already contain query parameters (e.g. from Link headers) instead of unconditionally appending
?per_page=100. My project has more than 100 releases and this fixes it.In addition, the reqwest HTTP client is configured with a 30s connect timeout and a 300s overall timeout (and imports Duration) to avoid long-hanging requests. These changes fix malformed pagination requests and make network calls more resilient.